Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp1604856pxb; Thu, 4 Mar 2021 16:07:19 -0800 (PST) X-Google-Smtp-Source: ABdhPJx2XB0NOHb4uI3fO0gLvr6adteBXo2vBX6c4HpxsQjslIrztk0I3jQ8XSP5nKFIHe0Xi1ed X-Received: by 2002:a05:6e02:12c2:: with SMTP id i2mr5880606ilm.34.1614902839000; Thu, 04 Mar 2021 16:07:19 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1614902838; cv=none; d=google.com; s=arc-20160816; b=BeHI7bPm6UgaTpAISBbYk2F3wtO31u60lT5BvQrdO2bmTfsSKr5ASKuQtWRsQB/kw+ naCuyPaOXQmA+zNRRwiOf/UKKwD3PdosuualCEEcjDEWzRfplRTEx2BacuOhNqJPHWD6 d5JP7CdM3UJnmhcREgDjLXlCkYxl9MMmfJepUeUYtYAEkjdoOpTvIzr+SQAofhJJM9n9 /Ju4QaaZPTUgfRWCMl3hHgjH+I9bGtsaLEU+IPMHALE+BgzN7d3dGM4qCCykKc8d+Dob FmfdmPfBAKIxstXnc2vz9nUZyDCL+dAuvdkeEGFRfbZ8FmfnSAg4X17T2ekq4jQxIbwy kPJg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=LT1jdvqxAsqfTeBRSvVBacjDtXTFJ9KYR4UQkQe2fdM=; b=gvOIxd6HZHFCWqQJmz8yEyqDNd1JhkGtQ2813gPI9ywLg+0U8N979tv+c0sSJVnEk3 m3xis0W6jIudOSWIKDeQmpH5GhRGAwXDLvSZH7XSNHh3XzbmTjy6x/gN+2Lw5NghIKzW 5T6SyCvMRtFo8q8Pc19Ab3Bpd96fGQGM9yoTLDbo+W5eefrT8NYR0BXWYnyAPi6efGLH Izv+CjmCojnceo40u73OUaki8FZ7LZSSU01zEfp7D2G1i1MsC53xDtx0+itqPjBA8mO2 ex8JEiBSg2Z2KNz8tPAvXHaOnHDk8gIJmH/HYIF8yGP9zmKl8cXhRNnbPIDQsSk4QrHE 6tIA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=PvdOBBkB; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id i4si1019992iov.52.2021.03.04.16.07.05; Thu, 04 Mar 2021 16:07:18 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=PvdOBBkB; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236131AbhCDIiV (ORCPT + 99 others); Thu, 4 Mar 2021 03:38:21 -0500 Received: from mail.kernel.org ([198.145.29.99]:54112 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235938AbhCDIhv (ORCPT ); Thu, 4 Mar 2021 03:37:51 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id DE66C64EFE; Thu, 4 Mar 2021 08:37:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1614847030; bh=QT2ORfbTBUd5cxY+IDZbENy/xwp9khoZXS4cpegFUak=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=PvdOBBkBBhyRVWE2g/99cH+tHjhf1vd0QIKJdYhQgHPxIQHxx/qgZbzaUXfM0n9/l cx86nfcgfooxXdYSmMn7meKQUJnJivFuG7nBqKzzyw5yC44M9sdVROGay1SzO6RMh6 UPiJnk1CS/gQD7fh/BN1GeJkp+m7dfHe1Ge6YbgE= Date: Thu, 4 Mar 2021 09:37:07 +0100 From: Greg KH To: Qiang Ma Cc: arnd@arndb.de, linux-kernel@vger.kernel.org Subject: Re: [PATCH] char: lp: remove redundant space Message-ID: References: <20210304081752.23986-1-maqianga@uniontech.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210304081752.23986-1-maqianga@uniontech.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 04, 2021 at 04:17:52PM +0800, Qiang Ma wrote: > These two lines of code don't meet the kernel coding style, > so remove the redundant space. > > Signed-off-by: Qiang Ma > --- > drivers/char/lp.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/char/lp.c b/drivers/char/lp.c > index 862c2fd933c7..0e22e3b0a04e 100644 > --- a/drivers/char/lp.c > +++ b/drivers/char/lp.c > @@ -546,7 +546,7 @@ static int lp_open(struct inode *inode, struct file *file) > } > /* Determine if the peripheral supports ECP mode */ > lp_claim_parport_or_block(&lp_table[minor]); > - if ( (lp_table[minor].dev->port->modes & PARPORT_MODE_ECP) && > + if ((lp_table[minor].dev->port->modes & PARPORT_MODE_ECP) && > !parport_negotiate(lp_table[minor].dev->port, > IEEE1284_MODE_ECP)) { > printk(KERN_INFO "lp%d: ECP mode\n", minor); > @@ -590,7 +590,7 @@ static int lp_do_ioctl(unsigned int minor, unsigned int cmd, > return -ENODEV; > if ((LP_F(minor) & LP_EXIST) == 0) > return -ENODEV; > - switch ( cmd ) { > + switch (cmd) { > case LPTIME: > if (arg > UINT_MAX / HZ) > return -EINVAL; > -- > 2.20.1 > > > Hi, This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him a patch that has triggered this response. He used to manually respond to these common problems, but in order to save his sanity (he kept writing the same thing over and over, yet to different people), I was created. Hopefully you will not take offence and will fix the problem in your patch and resubmit it so that it can be accepted into the Linux kernel tree. You are receiving this message because of the following common error(s) as indicated below: - This looks like a new version of a previously submitted patch, but you did not list below the --- line any changes from the previous version. Please read the section entitled "The canonical patch format" in the kernel file, Documentation/SubmittingPatches for what needs to be done here to properly describe this. If you wish to discuss this problem further, or you have questions about how to resolve this issue, please feel free to respond to this email and Greg will reply once he has dug out from the pending patches received from other developers. thanks, greg k-h's patch email bot