Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v7 2/4] perf tools: Add lexical definition of event name
To:     Shunsuke Nakamura <nakamura.shun@fujitsu.com>, <will@kernel.org>,
        <mathieu.poirier@linaro.org>, <leo.yan@linaro.org>,
        <peterz@infradead.org>, <mingo@redhat.com>, <acme@kernel.org>,
        <mark.rutland@arm.com>, <alexander.shishkin@linux.intel.com>,
        <jolsa@redhat.com>, <namhyung@kernel.org>
CC:     <linux-arm-kernel@lists.infradead.org>,
        <linux-kernel@vger.kernel.org>
References: <20210304032610.3112996-1-nakamura.shun@fujitsu.com>
 <20210304032610.3112996-3-nakamura.shun@fujitsu.com>
From:   John Garry <john.garry@huawei.com>
Message-ID: <74955041-45ab-10df-e044-5d64898c81d9@huawei.com>
Date:   Thu, 4 Mar 2021 09:34:44 +0000
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101
 Thunderbird/68.1.2
MIME-Version: 1.0
In-Reply-To: <20210304032610.3112996-3-nakamura.shun@fujitsu.com>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 04/03/2021 03:26, Shunsuke Nakamura wrote:
> From: Shunsuke Nakamura <nakamura.shun@jp.fujitsu.com>
> 
> Add the lexical definition of event name so that the numbers are recognizable.
> 

Sorry for the hassle, but it's not clear that we got a definitive 
conclusion on this patch from v6 series:

https://lore.kernel.org/lkml/YCuo01Wxxe%2FMCrC5@krava/

Would it be so much worse for you to change format of these event names 
to not start with a numberic?

Thanks


> A64FX defines an event name that starts with a number.
>   - 0inst_commit
>   - 1inst_commit
>   - 2inst_commit
>   - 3inst_commit
>   - 4inst_commit
> 
> Signed-off-by: Shunsuke Nakamura <nakamura.shun@fujitsu.com>
> Acked-by: John Garry <john.garry@huawei.com>
> ---
>   tools/perf/util/parse-events.l | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/perf/util/parse-events.l b/tools/perf/util/parse-events.l
> index 0b36285a9435..33f627187415 100644
> --- a/tools/perf/util/parse-events.l
> +++ b/tools/perf/util/parse-events.l
> @@ -205,7 +205,7 @@ bpf_source	[^,{}]+\.c[a-zA-Z0-9._]*
>   num_dec		[0-9]+
>   num_hex		0x[a-fA-F0-9]+
>   num_raw_hex	[a-fA-F0-9]+
> -name		[a-zA-Z_*?\[\]][a-zA-Z0-9_*?.\[\]]*
> +name		[a-zA-Z0-9_*?\[\]][a-zA-Z0-9_*?.\[\]]*
>   name_tag	[\'][a-zA-Z_*?\[\]][a-zA-Z0-9_*?\-,\.\[\]:=]*[\']
>   name_minus	[a-zA-Z_*?][a-zA-Z0-9\-_*?.:]*
>   drv_cfg_term	[a-zA-Z0-9_\.]+(=[a-zA-Z0-9_*?\.:]+)?
>