Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210302163309.25528-1-henning.schild@siemens.com> <20210302163309.25528-5-henning.schild@siemens.com>
In-Reply-To: <20210302163309.25528-5-henning.schild@siemens.com>
From:   Andy Shevchenko <andy.shevchenko@gmail.com>
Date:   Thu, 4 Mar 2021 11:50:52 +0200
Message-ID: <CAHp75Vf1gkb+qWhv7a5Q3Bf-brDkMsOKdFo4ckSpG2e-7bqWng@mail.gmail.com>
Subject: Re: [PATCH 4/4] platform/x86: pmc_atom: improve critclk_systems
 matching for Siemens PCs
To:     Henning Schild <henning.schild@siemens.com>
Cc:     Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Linux LED Subsystem <linux-leds@vger.kernel.org>,
        Platform Driver <platform-driver-x86@vger.kernel.org>,
        linux-watchdog@vger.kernel.org,
        Srikanth Krishnakar <skrishnakar@gmail.com>,
        Jan Kiszka <jan.kiszka@siemens.com>,
        Gerd Haeussler <gerd.haeussler.ext@siemens.com>,
        Guenter Roeck <linux@roeck-us.net>,
        Wim Van Sebroeck <wim@linux-watchdog.org>,
        Mark Gross <mgross@linux.intel.com>,
        Hans de Goede <hdegoede@redhat.com>,
        Pavel Machek <pavel@ucw.cz>,
        Michael Haener <michael.haener@siemens.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Thu, Mar 4, 2021 at 9:27 AM Henning Schild
<henning.schild@siemens.com> wrote:

> Siemens industrial PCs unfortunately can not always be properly
> identified the way we used to. An earlier commit introduced code that
> allows proper identification without looking at DMI strings that could
> differ based on product branding.
> Switch over to that proper way and revert commits that used to collect
> the machines based on unstable strings.

> +#include <linux/platform_data/x86/simatic-ipc.h>

> +static int pmc_clk_is_critical(const struct dmi_system_id *d)
> +{
> +       int ret = true;
> +       u32 station_id;
> +
> +       if (!strcmp(d->ident, "SIEMENS AG")) {
> +               if (dmi_walk(simatic_ipc_find_dmi_entry_helper, &station_id))
> +                       ret = false;
> +               else
> +                       ret = (station_id == SIMATIC_IPC_IPC227E ||
> +                              station_id == SIMATIC_IPC_IPC277E);
> +       }
> +
> +       return ret;

Much easier to rewrite it as

if (strcmp(...)) // BTW, do we have a dmi_* helper for that?
  return true;

if (dmi_walk)
  return false;

return station_id == || ...;

> +}

Maybe instead you can rewrite it as a callback in DMI table which
changes a (global, yeah) variable that you simply reassign...


>         if (d) {
> -               clk_data->critical = true;
> -               pr_info("%s critclks quirk enabled\n", d->ident);
> +               clk_data->critical = pmc_clk_is_critical(d);
> +               if (clk_data->critical)
> +                       pr_info("%s critclks quirk enabled\n", d->ident);
>         }

...somewhere here?

Like
  clk_data->critical = global_var;
  if (...)
    pr_info();

It seems it will reduce burden on a callback by dropping strcmp() call.

-- 
With Best Regards,
Andy Shevchenko