Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Content-Type: text/plain;
        charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.60.0.2.21\))
Subject: Re: [PATCH v4 05/15] pinctrl: add a pincontrol driver for BCM6328
From:   =?utf-8?Q?=C3=81lvaro_Fern=C3=A1ndez_Rojas?= <noltari@gmail.com>
In-Reply-To: <CAHp75Vc8Gk0ZVjfQH71-Du1ZB1HT5qrgbT6HZgXQd-C6xE05ZQ@mail.gmail.com>
Date:   Thu, 4 Mar 2021 12:13:04 +0100
Cc:     Linus Walleij <linus.walleij@linaro.org>,
        Rob Herring <robh+dt@kernel.org>,
        Michael Walle <michael@walle.cc>,
        Bartosz Golaszewski <bgolaszewski@baylibre.com>,
        Florian Fainelli <f.fainelli@gmail.com>,
        bcm-kernel-feedback-list <bcm-kernel-feedback-list@broadcom.com>,
        Jonas Gorski <jonas.gorski@gmail.com>,
        Necip Fazil Yildiran <fazilyildiran@gmail.com>,
        "open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
        devicetree <devicetree@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        linux-arm Mailing List <linux-arm-kernel@lists.infradead.org>
Content-Transfer-Encoding: quoted-printable
Message-Id: <F56A2594-5E16-457F-B170-D9D14E6592FE@gmail.com>
References: <20210304085710.7128-1-noltari@gmail.com>
 <20210304085710.7128-6-noltari@gmail.com>
 <CAHp75Vc8Gk0ZVjfQH71-Du1ZB1HT5qrgbT6HZgXQd-C6xE05ZQ@mail.gmail.com>
To:     Andy Shevchenko <andy.shevchenko@gmail.com>
Precedence: bulk

Hi Andy,

> El 4 mar 2021, a las 11:49, Andy Shevchenko =
<andy.shevchenko@gmail.com> escribi=C3=B3:
>=20
> On Thu, Mar 4, 2021 at 10:57 AM =C3=81lvaro Fern=C3=A1ndez Rojas
> <noltari@gmail.com> wrote:
>>=20
>> Add a pincontrol driver for BCM6328. BCM628 supports muxing 32 pins =
as
>> GPIOs, as LEDs for the integrated LED controller, or various other
>> functions. Its pincontrol mux registers also control other aspects, =
like
>> switching the second USB port between host and device mode.
>=20
> ...
>=20
>> +static inline unsigned int bcm6328_mux_off(unsigned int pin)
>> +{
>> +       static const unsigned int bcm6328_mux[] =3D {
>> +               BCM6328_MUX_LO_REG,
>> +               BCM6328_MUX_HI_REG,
>=20
>> +               BCM6328_MUX_OTHER_REG
>=20
> When it's not terminator add a comma, otherwise remove a comma.

=E2=80=A6 so you want me to add a comma or not?

>=20
> Also, why is it inside a function? It's anyway global and constant.

Because this is only used by this function and I=E2=80=99m used to doing =
this to comply with MISRA C 2004 at work :)

>=20
>> +       };
>=20
> ...
>=20
>> +       regmap_update_bits(pc->regs, bcm6328_mux_off(pin),
>> +                          3UL << ((pin % 16) * 2),
>=20
> 3UL =3D> #define BLABLA  GENMASK(1, 0)

Ok, I will add a define for this.

>=20
>> +                          mux << ((pin % 16) * 2));
>=20
> ...
>=20
>> +static const struct of_device_id bcm6328_pinctrl_match[] =3D {
>> +       { .compatible =3D "brcm,bcm6328-pinctrl", },
>> +       { },
>=20
> No comma.

Ok, I will remove the comma.

>=20
>> +};
>=20
> Above comments to all your patches.

Ok, I will try to address all of this comments in v5.

>=20
> --=20
> With Best Regards,
> Andy Shevchenko