Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <eda54f59067bdefd13af9ad9c5c254cb1b04049b.camel@pengutronix.de>
Subject: Re: [PATCH v4 06/13] phy: cadence: cadence-sierra: Move all
 reset_control_get*() to a separate function
From:   Philipp Zabel <p.zabel@pengutronix.de>
To:     Kishon Vijay Abraham I <kishon@ti.com>,
        Vinod Koul <vkoul@kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        Swapnil Jakhade <sjakhade@cadence.com>
Cc:     linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
        Lokesh Vutla <lokeshvutla@ti.com>
Date:   Thu, 04 Mar 2021 12:54:21 +0100
In-Reply-To: <20210304044122.15166-7-kishon@ti.com>
References: <20210304044122.15166-1-kishon@ti.com>
         <20210304044122.15166-7-kishon@ti.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8BIT
User-Agent: Evolution 3.30.5-1.1 
MIME-Version: 1.0
Precedence: bulk

On Thu, 2021-03-04 at 10:11 +0530, Kishon Vijay Abraham I wrote:
> No functional change. Group devm_reset_control_get() and
> devm_reset_control_get_optional() to a separate function.
> 
> Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
> ---
>  drivers/phy/cadence/phy-cadence-sierra.c | 36 ++++++++++++++++--------
>  1 file changed, 25 insertions(+), 11 deletions(-)
> 
> diff --git a/drivers/phy/cadence/phy-cadence-sierra.c b/drivers/phy/cadence/phy-cadence-sierra.c
> index 7bf1b4c7774a..935f165404e4 100644
> --- a/drivers/phy/cadence/phy-cadence-sierra.c
> +++ b/drivers/phy/cadence/phy-cadence-sierra.c
> @@ -509,6 +509,28 @@ static int cdns_sierra_phy_get_clocks(struct cdns_sierra_phy *sp,
>  	return 0;
>  }
>  
> +static int cdns_sierra_phy_get_resets(struct cdns_sierra_phy *sp,
> +				      struct device *dev)
> +{
> +	struct reset_control *rst;
> +
> +	rst = devm_reset_control_get(dev, "sierra_reset");

Please use
	rst = devm_reset_control_get_exclusive(dev, "sierra_reset");
here ...

> +	if (IS_ERR(rst)) {
> +		dev_err(dev, "failed to get reset\n");
> +		return PTR_ERR(rst);
> +	}
> +	sp->phy_rst = rst;
> +
> +	rst = devm_reset_control_get_optional(dev, "sierra_apb");

... and
	rst = devm_reset_control_get_optional_exclusive(dev, "sierra_apb");	
here (no functional change).

With that,

Reviewed-by: Philipp Zabel <p.zabel@pengutronix.de>

regards
Philipp