Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Content-Type: text/plain;
        charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.60.0.2.21\))
Subject: Re: [PATCH v4 03/15] pinctrl: bcm: add bcm63xx base code
From:   =?utf-8?Q?=C3=81lvaro_Fern=C3=A1ndez_Rojas?= <noltari@gmail.com>
In-Reply-To: <CAHp75VdzgSyz24xtDiniM40-tjRjKipzdtFvd=Fq=-Xbvr-amw@mail.gmail.com>
Date:   Thu, 4 Mar 2021 13:28:26 +0100
Cc:     Linus Walleij <linus.walleij@linaro.org>,
        Rob Herring <robh+dt@kernel.org>,
        Michael Walle <michael@walle.cc>,
        Bartosz Golaszewski <bgolaszewski@baylibre.com>,
        Florian Fainelli <f.fainelli@gmail.com>,
        bcm-kernel-feedback-list <bcm-kernel-feedback-list@broadcom.com>,
        Necip Fazil Yildiran <fazilyildiran@gmail.com>,
        "open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
        devicetree <devicetree@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        linux-arm Mailing List <linux-arm-kernel@lists.infradead.org>
Content-Transfer-Encoding: quoted-printable
Message-Id: <3E07960B-BB4B-4647-A1FD-E291F9FD6D74@gmail.com>
References: <20210304085710.7128-1-noltari@gmail.com>
 <20210304085710.7128-4-noltari@gmail.com>
 <CAHp75Vc_v5M9XjWei09KzXo_oo95b2WQSamMjdQvxkCzNXrSXg@mail.gmail.com>
 <667E0AEF-B453-4CC7-9514-5E72BEF4B0E3@gmail.com>
 <CAHp75VdzgSyz24xtDiniM40-tjRjKipzdtFvd=Fq=-Xbvr-amw@mail.gmail.com>
To:     Andy Shevchenko <andy.shevchenko@gmail.com>,
        Jonas Gorski <jonas.gorski@gmail.com>
Precedence: bulk

Hi Andy,

> El 4 mar 2021, a las 13:09, Andy Shevchenko =
<andy.shevchenko@gmail.com> escribi=C3=B3:
>=20
> On Thu, Mar 4, 2021 at 1:17 PM =C3=81lvaro Fern=C3=A1ndez Rojas =
<noltari@gmail.com> wrote:
>>> El 4 mar 2021, a las 11:43, Andy Shevchenko =
<andy.shevchenko@gmail.com> escribi=C3=B3:
>>> On Thu, Mar 4, 2021 at 10:57 AM =C3=81lvaro Fern=C3=A1ndez Rojas
>>> <noltari@gmail.com> wrote:
>>>>=20
>>>> Add a helper for registering BCM63XX pin controllers.
>>>>=20
>>>> Signed-off-by: =C3=81lvaro Fern=C3=A1ndez Rojas <noltari@gmail.com>
>>>> Signed-off-by: Jonas Gorski <jonas.gorski@gmail.com>
>>>=20
>>> This SoB is in a strange place.
>>=20
>> Why?
>> Can=E2=80=99t we both sign the patches?
>=20
> You can, but you have to follow the rules (see chapters 11-13 in the =
[1]).
>=20
>>> The order is wrong taking into account the =46rom header =
(committer). So,
>>> it's not clear who is the author, who is a co-developer, and who is
>>> the committer (one person may utilize few roles).
>>> Check for the rest of the series as well (basically this is the rule
>>> of thumb to recheck entire code for the comment you have got at any
>>> single place of it).
>>=20
>> Jonas was the original author of this patches (sent back in 2016) and =
I=E2=80=99m just continuing his work and trying to get those patches =
upstreamed.
>> I don=E2=80=99t know how to do it correctly, so a little hint would =
be appreciated.
>=20
> There are two ways (depends on the amount of work you have done):
> - leave him as an original author (so Author field will have his name,
> not yours) and apply yours with Co-developed-by tag and SoB since you
> are co-developed and committed
> - other way around

So I will move his SoB to the top, add a Co-developed-by referencing him =
before that and then leave my SoB as the last one.
@Jonas are you OK with that?

>=20
> [1]: =
https://www.kernel.org/doc/html/latest/process/submitting-patches.html#sig=
n-your-work-the-developer-s-certificate-of-origin
>=20
> ...
>=20
>>>> +#include <linux/pinctrl/pinctrl.h>
>>>> +#include <linux/regmap.h>
>>>=20
>>> The rule of thumb is to include only the headers that the below code
>>> is direct user of.
>>=20
>> Ok, so I will move them to pinctrl-bcm63xx.c.
>> I added them because they were needed for pinctrl_desc.
>=20
> Ah, for that yes, you need a header.
>=20
>>> The above are not used anyhow, while missed types.h and several
>>> forward declarations.
>>=20
>> =E2=80=A6 so I should include linux/types.h and I don=E2=80=99t know =
what you mean by =E2=80=9Cseveral forward declarations=E2=80=9D=E2=80=A6
>=20
> Like
>=20
> struct regmap;
>=20
> which effectively tells the compiler that "hey, this type is defined
> somewhere else".
>=20
> --=20
> With Best Regards,
> Andy Shevchenko

Best regards,
=C3=81lvaro.=