Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 4 Mar 2021 16:26:18 +0100
From:   Marc Kleine-Budde <mkl@pengutronix.de>
To:     Dario Binacchi <dariobin@libero.it>
Cc:     linux-kernel@vger.kernel.org,
        Alexander Stein <alexander.stein@systec-electronic.com>,
        Federico Vaga <federico.vaga@gmail.com>,
        "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        Oliver Hartkopp <socketcan@hartkopp.net>,
        Vincent Mailhol <mailhol.vincent@wanadoo.fr>,
        Wolfgang Grandegger <wg@grandegger.com>,
        YueHaibing <yuehaibing@huawei.com>,
        Zhang Qilong <zhangqilong3@huawei.com>,
        linux-can@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH v4 5/6] can: c_can: prepare to up the message objects
 number
Message-ID: <20210304152618.rqajqmzcqqhszfem@pengutronix.de>
References: <20210302215435.18286-1-dariobin@libero.it>
 <20210302215435.18286-6-dariobin@libero.it>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="wgmmyfwmn76i5d4s"
Content-Disposition: inline
In-Reply-To: <20210302215435.18286-6-dariobin@libero.it>
Precedence: bulk


--wgmmyfwmn76i5d4s
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On 02.03.2021 22:54:34, Dario Binacchi wrote:
> diff --git a/drivers/net/can/c_can/c_can.c b/drivers/net/can/c_can/c_can.c
> index 77b9aee56154..0052ba5197e0 100644
> --- a/drivers/net/can/c_can/c_can.c
> +++ b/drivers/net/can/c_can/c_can.c
[...]
> -struct net_device *alloc_c_can_dev(void)
> +struct net_device *alloc_c_can_dev(int msg_obj_num)
>  {
>  	struct net_device *dev;
>  	struct c_can_priv *priv;
> +	int msg_obj_tx_num =3D msg_obj_num / 2;
> =20
> -	dev =3D alloc_candev(sizeof(struct c_can_priv), C_CAN_MSG_OBJ_TX_NUM);
> +	dev =3D alloc_candev(sizeof(*priv) + sizeof(u32) * msg_obj_tx_num,
> +			   msg_obj_tx_num);

I've converted this to make use of the struct_size() macro:

+       dev =3D alloc_candev(struct_size(priv, dlc, msg_obj_tx_num),
+                          msg_obj_tx_num);

regards,
Marc

--=20
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |

--wgmmyfwmn76i5d4s
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEK3kIWJt9yTYMP3ehqclaivrt76kFAmBA/BgACgkQqclaivrt
76m4zwgAny/+Z6viYUgp3sOUmSnJzENe19yvsk7JUDQ10FUvBTGDASIHY9qEg+Sn
nJ1EDa8d37+SO7SYusaiogXzxV61vnZSmvfrzERCN8kH4jVRscNXd6tD12P04FDS
6Jj+Oks0+hYL0+9r8qzR9NPZzoxWqWbUyGk4tEnYFQ84LALZjmWpEeOv/ORKv6UI
KJPTl1asXcVOj1gyq0AvAHaND0Ei+t2lmej5iA4dxxdi8dIt1nYq+tDo8IGl5jqa
cPaP4jKopOHMaOgwYzpPieG4NXoBvai3XxfxjP+ZWUB70MU3YfP5JCn0m+tqAOsh
bshqNyienPr57S0oyUuXkt9zikG61w==
=LgIH
-----END PGP SIGNATURE-----

--wgmmyfwmn76i5d4s--