Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: L+YvIEQo6IVN7SRUqnMazJ+7oV1cqcZ5a/lVYCpNC+O03NYWw4eQV4Uclm8Jd3YWns1bNGVgj6
 MAHU105Bmadw==
IronPort-SDR: gQH/rLO8VgxKvIU/P5wEfLdvQ+FOHXuGAafk93GTP3GD/Xbj1jh86gWrvQhhBV5HVhk7LSjSne
 CF1bONpvK+sA==
Date:   Thu, 4 Mar 2021 17:41:45 +0200
From:   Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To:     Mika Westerberg <mika.westerberg@linux.intel.com>
Cc:     linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
        Andy Shevchenko <andy@kernel.org>,
        Linus Walleij <linus.walleij@linaro.org>
Subject: Re: [PATCH v1 1/1] pinctrl: intel: No need to disable IRQs in the
 handler
Message-ID: <YED/uRFrllsgakCF@smile.fi.intel.com>
References: <20210304105432.36544-1-andriy.shevchenko@linux.intel.com>
 <20210304111809.GO2542@lahna.fi.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210304111809.GO2542@lahna.fi.intel.com>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
Precedence: bulk

On Thu, Mar 04, 2021 at 01:18:09PM +0200, Mika Westerberg wrote:
> On Thu, Mar 04, 2021 at 12:54:32PM +0200, Andy Shevchenko wrote:
> > In IRQ handler interrupts are already disabled, hence no need
> > to repeat it. Even in the threaded case, which is disabled here,
> > it is not a problem because IRQ framework serializes descriptor
> > handling. Remove disabling IRQ part in the handler.
> > 
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> 
> Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>

Pushed to my review and testing queue, thanks!

-- 
With Best Regards,
Andy Shevchenko