Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp1626066pxb; Thu, 4 Mar 2021 16:49:04 -0800 (PST) X-Google-Smtp-Source: ABdhPJxgabXaEPVL9uWjYCpPrkio9ExtZn4zatCKJQjIoLUtcU3EXiYN4nrezzW1in/qiQiOZA1B X-Received: by 2002:a92:60a:: with SMTP id x10mr6341435ilg.262.1614905343806; Thu, 04 Mar 2021 16:49:03 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1614905343; cv=none; d=google.com; s=arc-20160816; b=trFsOiS3oole0pMWLpvPXPWRz+XnDymmxCgJomJv3zgyU06CtsO66O6CrHBXmimhSe Fjm7FdUOE3a1nImIQGduA2+PZIOavmUYz8R7g9jhkbJJt3Gd2L/9wZ+uIdXi7cj5P+7n HCyJhbfRYOGTymtqdrXsalJLnJX93tET09cj8YRQfShLCkMlXf3jg8aDW4VzxNJIE4pe rSDlvp399LTZAWYWwtGb+8B10olmyb5HVcc/MuYFICPg7VVHn/fWGFmqsCQZlqk1Lsdc +4lApQz/MG8UefJPrs8raF8y0ZxtOC6uD4IKcICdtm2I4DaQKiQ8PuVI9mdZVCf1+9mz tXeQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=o7bEkba2zcLNw+pIfx6JiAaDaNR178CGxg2NH0WBdYo=; b=hUkVv2fHR/kk0QKETbcFP8d1zhvD0Tmmd6VV8mNjqoEtnltetcoJCkbHmRSwnb0uam mCVyS1KWMscipOPvxq96hlpN1fDHaXqW82jWlZgjFKRjB0jXnP2pmavUNVQcvgwSc80i ROhC273PpWU2P2UXCAcJLF5LL+jbcjgyRbPe/xkoKtRz4XTSrVRUFqWSu0ZjyI+M9bNW mbVEpBVvXYzzYTh3AsF/Xk76Mb4PVL9zts8EHwMlHSdX5nvI8aRdFL28fEhjpReBKKtd ITpRnOzLqXq51rDpEsEpfzXjLq+mJb+i03F6wcWmzQ8Xcgio0sVgy7nskcvK3EfkwDC1 ZECQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@foss.st.com header.s=selector1 header.b=IIXC1dRm; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=foss.st.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id t15si509173jal.2.2021.03.04.16.48.50; Thu, 04 Mar 2021 16:49:03 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@foss.st.com header.s=selector1 header.b=IIXC1dRm; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=foss.st.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237025AbhCDQYf (ORCPT + 99 others); Thu, 4 Mar 2021 11:24:35 -0500 Received: from mx08-00178001.pphosted.com ([91.207.212.93]:21678 "EHLO mx07-00178001.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S237035AbhCDQYJ (ORCPT ); Thu, 4 Mar 2021 11:24:09 -0500 Received: from pps.filterd (m0046660.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 124GCFxp027811; Thu, 4 Mar 2021 17:23:19 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foss.st.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-type; s=selector1; bh=o7bEkba2zcLNw+pIfx6JiAaDaNR178CGxg2NH0WBdYo=; b=IIXC1dRmvFyMk4ICNX371yCoI8KtjHkiWPPtbL5VkSrwYAXcRhDNf/7/kpII3rKX0DZU QrfGpjEtS/oOB6dKyBS2cLAD38b0DYYXzC4Y/OArikZeeg7ixjam/jTH6NzU/X1trnUe QGNsCvsbTiInNTp/3S2aLElJ+EpmLLp11RIGWcch2PT8fAMZnOdHFD93nzwMh9salWrW zypHrzMV8udZlLydvG4Jt0CQ+17Kq8W3AR+DJnHX5/MjRSww1n3mbRjtkCTEaPBhsTn9 iFDZlPrsc4PThPdkZ7WlfWkhLhjt3ixy22PEjX8zeI/g8vhsnBro6mSUZl4SbQTSNrXv Xw== Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by mx07-00178001.pphosted.com with ESMTP id 36yfdygh3s-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 04 Mar 2021 17:23:19 +0100 Received: from euls16034.sgp.st.com (euls16034.sgp.st.com [10.75.44.20]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id A9586100034; Thu, 4 Mar 2021 17:23:18 +0100 (CET) Received: from Webmail-eu.st.com (sfhdag2node3.st.com [10.75.127.6]) by euls16034.sgp.st.com (STMicroelectronics) with ESMTP id 99DAD20741B; Thu, 4 Mar 2021 17:23:18 +0100 (CET) Received: from localhost (10.75.127.51) by SFHDAG2NODE3.st.com (10.75.127.6) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Thu, 4 Mar 2021 17:23:18 +0100 From: Erwan Le Ray To: Greg Kroah-Hartman , Jiri Slaby , Maxime Coquelin , Alexandre Torgue CC: , , , , Erwan Le Ray , Fabrice Gasnier , Valentin Caron Subject: [PATCH v2 09/13] serial: stm32: call stm32_transmit_chars locked Date: Thu, 4 Mar 2021 17:23:04 +0100 Message-ID: <20210304162308.8984-10-erwan.leray@foss.st.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20210304162308.8984-1-erwan.leray@foss.st.com> References: <20210304162308.8984-1-erwan.leray@foss.st.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.75.127.51] X-ClientProxiedBy: SFHDAG3NODE2.st.com (10.75.127.8) To SFHDAG2NODE3.st.com (10.75.127.6) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.369,18.0.761 definitions=2021-03-04_05:2021-03-03,2021-03-04 signatures=0 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org stm32_transmit_chars should be called under lock also in tx DMA callback. Fixes: 3489187204eb ("serial: stm32: adding dma support") Signed-off-by: Erwan Le Ray Signed-off-by: Fabrice Gasnier diff --git a/drivers/tty/serial/stm32-usart.c b/drivers/tty/serial/stm32-usart.c index 74046ae3a412..2bdd04a47f91 100644 --- a/drivers/tty/serial/stm32-usart.c +++ b/drivers/tty/serial/stm32-usart.c @@ -291,13 +291,16 @@ static void stm32_usart_tx_dma_complete(void *arg) struct uart_port *port = arg; struct stm32_port *stm32port = to_stm32_port(port); const struct stm32_usart_offsets *ofs = &stm32port->info->ofs; + unsigned long flags; dmaengine_terminate_async(stm32port->tx_ch); stm32_usart_clr_bits(port, ofs->cr3, USART_CR3_DMAT); stm32port->tx_dma_busy = false; /* Let's see if we have pending data to send */ + spin_lock_irqsave(&port->lock, flags); stm32_usart_transmit_chars(port); + spin_unlock_irqrestore(&port->lock, flags); } static void stm32_usart_tx_interrupt_enable(struct uart_port *port) -- 2.17.1