Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: fkdQhbAQoVujyG+aTasdSoJ8oKYGHkRLqCgVt4N9jtJ7qo2GW8TyefmOQAqo9J3PpgwLr8FiJK
 +3kADcgC86kg==
IronPort-SDR: WVIlmacODEbag1qS3K/9hi0A+4uEB19iVvXOFpVz5Nbg2J2PUkZXiRZ7FVtsXHjGme1c22wNYk
 lqKsGVrk3zaw==
From:   "Moore, Robert" <robert.moore@intel.com>
To:     "Kaneda, Erik" <erik.kaneda@intel.com>,
        Weidong Cui <weidongcui@gmail.com>,
        "Wysocki, Rafael J" <rafael.j.wysocki@intel.com>
CC:     Xinyang Ge <aegiryy@gmail.com>,
        "linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
        "devel@acpica.org" <devel@acpica.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Len Brown <lenb@kernel.org>
Subject: RE: [PATCH] Enable ACPI_ADR_SPACE_PCI_CONFIG in
 acpi_gbl_default_address_spaces only when ACPI_PCI_CONFIGURED is defined
Thread-Topic: [PATCH] Enable ACPI_ADR_SPACE_PCI_CONFIG in
 acpi_gbl_default_address_spaces only when ACPI_PCI_CONFIGURED is defined
Thread-Index: AQHW/pI3ruT7cwkxjEOUSsZ8OrOy5apyuR4AgAF306A=
Date:   Thu, 4 Mar 2021 16:56:26 +0000
Message-ID: <BYAPR11MB325658379DB73F6EEDD6C76F87979@BYAPR11MB3256.namprd11.prod.outlook.com>
References: <20210209031744.26474-1-weidongcui@gmail.com>
 <MWHPR11MB1599D81078925FFD128E954EF0989@MWHPR11MB1599.namprd11.prod.outlook.com>
In-Reply-To: <MWHPR11MB1599D81078925FFD128E954EF0989@MWHPR11MB1599.namprd11.prod.outlook.com>
Accept-Language: en-US
Content-Language: en-US
dlp-version: 11.5.1.3
dlp-product: dlpe-windows
dlp-reaction: no-action
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: ed1e6995-139b-4673-7016-08d8df2e731b
X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Mar 2021 16:56:26.3843
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 0PWn6wrwyiYyWWBLjp0sWzkN9XAxwusuGPp+9Hvrq7fh44SLi5dBqHDDZzNwvgk4R1Ord3UwJ+cWkoTqQCAwpA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR11MB2631
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Well, I don't like the fact that PCI_CONFIGURED would have to be defined by=
 each current host:

> +#ifdef ACPI_PCI_CONFIGURED

I would rather the logic be reversed:

> +#ifdef ACPI_PCI_NOT_CONFIGURED

-----Original Message-----
From: Kaneda, Erik <erik.kaneda@intel.com>=20
Sent: Wednesday, March 03, 2021 10:29 AM
To: Weidong Cui <weidongcui@gmail.com>; Moore, Robert <robert.moore@intel.c=
om>; Wysocki, Rafael J <rafael.j.wysocki@intel.com>
Cc: Xinyang Ge <aegiryy@gmail.com>; linux-acpi@vger.kernel.org; devel@acpic=
a.org; linux-kernel@vger.kernel.org; Len Brown <lenb@kernel.org>
Subject: RE: [PATCH] Enable ACPI_ADR_SPACE_PCI_CONFIG in acpi_gbl_default_a=
ddress_spaces only when ACPI_PCI_CONFIGURED is defined

This looks good to me. Bob, do you have any comments?

Erik

> -----Original Message-----
> From: Weidong Cui <weidongcui@gmail.com>
> Sent: Monday, February 8, 2021 7:18 PM
> To: Moore, Robert <robert.moore@intel.com>; Kaneda, Erik=20
> <erik.kaneda@intel.com>; Wysocki, Rafael J=20
> <rafael.j.wysocki@intel.com>; Len Brown <lenb@kernel.org>
> Cc: Weidong Cui <weidongcui@gmail.com>; Xinyang Ge=20
> <aegiryy@gmail.com>; linux-acpi@vger.kernel.org; devel@acpica.org;=20
> linux- kernel@vger.kernel.org
> Subject: [PATCH] Enable ACPI_ADR_SPACE_PCI_CONFIG in=20
> acpi_gbl_default_address_spaces only when ACPI_PCI_CONFIGURED is=20
> defined
>=20
> Signed-off-by: Weidong Cui <weidongcui@gmail.com>
> Signed-off-by: Xinyang Ge <aegiryy@gmail.com>
> ---
>  drivers/acpi/acpica/evhandler.c | 2 ++
>  include/acpi/acconfig.h         | 4 ++++
>  2 files changed, 6 insertions(+)
>=20
> diff --git a/drivers/acpi/acpica/evhandler.c=20
> b/drivers/acpi/acpica/evhandler.c index 5884eba04..4c25ad433 100644
> --- a/drivers/acpi/acpica/evhandler.c
> +++ b/drivers/acpi/acpica/evhandler.c
> @@ -26,7 +26,9 @@ acpi_ev_install_handler(acpi_handle obj_handle,
>  u8 acpi_gbl_default_address_spaces[ACPI_NUM_DEFAULT_SPACES] =3D {
>  	ACPI_ADR_SPACE_SYSTEM_MEMORY,
>  	ACPI_ADR_SPACE_SYSTEM_IO,
> +#ifdef ACPI_PCI_CONFIGURED
>  	ACPI_ADR_SPACE_PCI_CONFIG,
> +#endif
>  	ACPI_ADR_SPACE_DATA_TABLE
>  };
>=20
> diff --git a/include/acpi/acconfig.h b/include/acpi/acconfig.h index=20
> a225eff49..790999028 100644
> --- a/include/acpi/acconfig.h
> +++ b/include/acpi/acconfig.h
> @@ -162,7 +162,11 @@
>  /* Maximum space_ids for Operation Regions */
>=20
>  #define ACPI_MAX_ADDRESS_SPACE          255
> +#ifdef ACPI_PCI_CONFIGURED
>  #define ACPI_NUM_DEFAULT_SPACES         4
> +#else
> +#define ACPI_NUM_DEFAULT_SPACES         3
> +#endif
>=20
>  /* Array sizes.  Used for range checking also */
>=20
> --
> 2.24.3 (Apple Git-128)