Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751095AbWI3P0p (ORCPT ); Sat, 30 Sep 2006 11:26:45 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751105AbWI3P0p (ORCPT ); Sat, 30 Sep 2006 11:26:45 -0400 Received: from stat9.steeleye.com ([209.192.50.41]:26835 "EHLO hancock.sc.steeleye.com") by vger.kernel.org with ESMTP id S1751095AbWI3P0o (ORCPT ); Sat, 30 Sep 2006 11:26:44 -0400 Subject: Re: 2.6.18-mm2 From: James Bottomley To: Frederik Deweerdt Cc: Alan Cox , Matthew Wilcox , "J.A. Magall??n" , Andrew Morton , "Linux-Kernel," , linux-scsi@vger.kernel.org In-Reply-To: <20060929235054.GB2020@slug> References: <20060928014623.ccc9b885.akpm@osdl.org> <20060929155738.7076f0c8@werewolf> <20060929143949.GL5017@parisc-linux.org> <1159550143.13029.36.camel@localhost.localdomain> <20060929235054.GB2020@slug> Content-Type: text/plain Date: Sat, 30 Sep 2006 10:26:22 -0500 Message-Id: <1159629982.14918.4.camel@mulgrave.il.steeleye.com> Mime-Version: 1.0 X-Mailer: Evolution 2.2.3 (2.2.3-4.fc4) Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 656 Lines: 26 On Fri, 2006-09-29 at 23:50 +0000, Frederik Deweerdt wrote: > + if (!pdev->irq) > + return -ENODEV; > + Don't I remember that 0 is a valid IRQ on some platforms? i.e. shouldn't this be if (pdev->irq == NO_IRQ) return -ENODEV; ? I think this won't quite work because only the platforms that actually have a valid zero irq define it, but there must be something else that works. James - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/