Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210304144317.78065-1-mheyne@amazon.de>
In-Reply-To: <20210304144317.78065-1-mheyne@amazon.de>
From:   Cong Wang <xiyou.wangcong@gmail.com>
Date:   Thu, 4 Mar 2021 12:50:10 -0800
Message-ID: <CAM_iQpWv2qhqmn_kcpO5i=Y8qpTFGoZe7HAVJ5NEGKrjuS0QQQ@mail.gmail.com>
Subject: Re: [PATCH] net: sched: avoid duplicates in classes dump
To:     Maximilian Heyne <mheyne@amazon.de>
Cc:     Jamal Hadi Salim <jhs@mojatatu.com>, Jiri Pirko <jiri@resnulli.us>,
        "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        Jiri Kosina <jkosina@suse.cz>,
        Linux Kernel Network Developers <netdev@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Thu, Mar 4, 2021 at 6:44 AM Maximilian Heyne <mheyne@amazon.de> wrote:
>
> This is a follow up of commit ea3274695353 ("net: sched: avoid
> duplicates in qdisc dump") which has fixed the issue only for the qdisc
> dump.
>
> The duplicate printing also occurs when dumping the classes via
>   tc class show dev eth0
>
> Fixes: 59cc1f61f09c ("net: sched: convert qdisc linked list to hashtable")
> Signed-off-by: Maximilian Heyne <mheyne@amazon.de>

Seems reasonable. If you can show the difference of tc class dump
before and after this patch in your changelog, it would be helpful to
understand the bug here.

Thanks.