Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Mime-Version: 1.0
Subject: RE: Re: [PATCH v26 4/4] scsi: ufs: Add HPB 2.0 support
Reply-To: daejun7.park@samsung.com
Sender: Daejun Park <daejun7.park@samsung.com>
From:   Daejun Park <daejun7.park@samsung.com>
To:     Bean Huo <huobean@gmail.com>,
        Daejun Park <daejun7.park@samsung.com>,
        Greg KH <gregkh@linuxfoundation.org>,
        "avri.altman@wdc.com" <avri.altman@wdc.com>,
        "jejb@linux.ibm.com" <jejb@linux.ibm.com>,
        "martin.petersen@oracle.com" <martin.petersen@oracle.com>,
        "asutoshd@codeaurora.org" <asutoshd@codeaurora.org>,
        "stanley.chu@mediatek.com" <stanley.chu@mediatek.com>,
        "cang@codeaurora.org" <cang@codeaurora.org>,
        "bvanassche@acm.org" <bvanassche@acm.org>,
        ALIM AKHTAR <alim.akhtar@samsung.com>
CC:     "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        JinHwan Park <jh.i.park@samsung.com>,
        Javier Gonzalez <javier.gonz@samsung.com>,
        SEUNGUK SHIN <seunguk.shin@samsung.com>,
        Sung-Jun Park <sungjun07.park@samsung.com>,
        Jinyoung CHOI <j-young.choi@samsung.com>,
        BoRam Shin <boram.shin@samsung.com>
In-Reply-To: <2f1b8ff5aec540ef731bf5b2c3691dd23ea2e6b0.camel@gmail.com>
Message-ID: <20210305002440epcms2p2205c56a96f6f8426fc1cb2d0cb7c16a3@epcms2p2>
Date:   Fri, 05 Mar 2021 09:24:40 +0900
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="utf-8"
CMS-TYPE: 102P
DLP-Filter: Pass
References: <2f1b8ff5aec540ef731bf5b2c3691dd23ea2e6b0.camel@gmail.com>
        <20210303062633epcms2p252227acd30ad15c1ca821d7e3f547b9e@epcms2p2>
        <20210303062926epcms2p6aa6737e5ed3916eed9ab80011aad3d83@epcms2p6>
        <CGME20210303062633epcms2p252227acd30ad15c1ca821d7e3f547b9e@epcms2p2>
Precedence: bulk

Hi Bean,

> > +
> > +static inline void ufshpb_put_pre_req(struct ufshpb_lu *hpb,
> > +                                     struct ufshpb_req *pre_req)
> > +{
> > +       pre_req->req = NULL;
> > +       pre_req->bio = NULL;
> > +       list_add_tail(&pre_req->list_req, &hpb->lh_pre_req_free);
> > +       hpb->num_inflight_pre_req--;
> > +}
> > +
> > +static void ufshpb_pre_req_compl_fn(struct request *req,
> > blk_status_t error)
> > +{
> > +       struct ufshpb_req *pre_req = (struct ufshpb_req *)req-
> > >end_io_data;
> > +       struct ufshpb_lu *hpb = pre_req->hpb;
> > +       unsigned long flags;
> > +       struct scsi_sense_hdr sshdr;
> > +
> > +       if (error) {
> > +               dev_err(&hpb->sdev_ufs_lu->sdev_dev, "block status
> > %d", error);
> > +               scsi_normalize_sense(pre_req->sense,
> > SCSI_SENSE_BUFFERSIZE,
> > +                                    &sshdr);
> > +               dev_err(&hpb->sdev_ufs_lu->sdev_dev,
> > +                       "code %x sense_key %x asc %x ascq %x",
> > +                       sshdr.response_code,
> > +                       sshdr.sense_key, sshdr.asc, sshdr.ascq);
> > +               dev_err(&hpb->sdev_ufs_lu->sdev_dev,
> > +                       "byte4 %x byte5 %x byte6 %x additional_len
> > %x",
> > +                       sshdr.byte4, sshdr.byte5,
> > +                       sshdr.byte6, sshdr.additional_length);
> > +       }
>  
>  
> How can you print out sense_key and sense code here? sense code will
> not be copied to pre_req->sense. you should directly use
> scsi_request->sense or let pre_req->sense point to scsi_request->sense.

OK, I will fix it.

> You update the new version patch so quickly. In another word, I am
> wondering if you tested your patch before submitting?

I will check more carefully for the next patch.

Thanks,
Daejun