Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 4 Mar 2021 17:21:20 -0800
From:   Andrew Morton <akpm@linux-foundation.org>
To:     Daniel Lezcano <daniel.lezcano@linaro.org>
Cc:     Andy Shevchenko <andy.shevchenko@gmail.com>,
        "rafael@kernel.org" <rafael@kernel.org>,
        Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        Lukasz Luba <lukasz.luba@arm.com>,
        open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] units: Add the HZ_PER_KHZ macro
Message-Id: <20210304172120.437d25238b880f5885e59142@linux-foundation.org>
In-Reply-To: <3ffdd3de-c30e-f237-7bd7-2700d426e53a@linaro.org>
References: <20210223203004.7219-1-daniel.lezcano@linaro.org>
        <CAHp75VcJwoye5KOYXF3Fs1F-82JPP-7VaU4z5OqBrYDr+AGQ5w@mail.gmail.com>
        <CAHp75Vcqug9qC_ejHE03YguiSy-XpsZV6g36-pe3VOFgTS2-tA@mail.gmail.com>
        <20210303163125.dcc0a086a939a58ed30750e8@linux-foundation.org>
        <3ffdd3de-c30e-f237-7bd7-2700d426e53a@linaro.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Thu, 4 Mar 2021 13:41:27 +0100 Daniel Lezcano <daniel.lezcano@linaro.org> wrote:

> > Also, why make them signed types?  Negative Hz is physically
> > nonsensical.  If that upsets some code somewhere because it was dealing
> > with signed types then, well, that code needed fixing anyway.
> > 
> > Ditto MILLIWATT_PER_WATT and friends, sigh.
> 
> At the first glance converting to unsigned long should not hurt the
> users of this macro.
> 
> The current series introduces the macro and its usage but by converting
> the existing type.
> 
> Is it ok if I send a separate series to change the units from L to UL?

That's the way to do it...