Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp1659626pxb; Thu, 4 Mar 2021 17:51:10 -0800 (PST) X-Google-Smtp-Source: ABdhPJw6oGTOcyzygxOAbBzC0G5O6Gt1A9Cys4XOqEKUPZGD6soj6XKXR3ccAM0IARWnHIGBXevr X-Received: by 2002:a05:6602:3144:: with SMTP id m4mr5486164ioy.103.1614909070173; Thu, 04 Mar 2021 17:51:10 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1614909070; cv=none; d=google.com; s=arc-20160816; b=I6sCyHNmTpSyZTuKwxKFe/hWXfzPNkbLe3unmo8L2BjgTb87KA8pG85trtd4JDJTGg 1GYGyfhwaQN3ZH7+7EkgZLZ6dzBR6vqpk1XIAdSResiNgdPFMvTa0aVYrNDaVOX7yrHT eMeLbnEirBaNGuYClLnCWGyxx+y48U60tIK08daoqL/8uz2CjmkVnZmVqzx2hRg8A3p5 frAzzDzVNfjTCFdKms2GXk393Ti2vA2vNYNuK0V6PTzz9/f8/bEPJngKmbw88zkC7lby Zs2dnqVLJDnAoQ3zTtlBVN3+bBoqzLZWyH2QImg/HDSQ0YggFDiOx0GdjZZBRsGgEMBW iOTg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-language:thread-index :content-transfer-encoding:mime-version:message-id:date:subject :in-reply-to:references:cc:to:from; bh=2UdqmajkpPRnVrypTBftaK/RUotbAugZKxilKVxAib4=; b=bzjPnccmBrv8ElPIZ+fyxT/p7QiE3TKXthLW9C5j9CZs2tbtHgY+5dgV6INIyDx1/W niphEaLBoyEmLPc4IknoH9BEnRvzRUdCGdJlmLFrmIdGIiZbBBq91SZcR1FHSd2U8W8n +kybM8AoXDgSCRG9iALA3+a8fcj+pNHjroefuQymyffiL73+6R5GKvkmbS6j8tPXEEqS TZMHn01mo4X7mE20YTcgM//+Sy3SaTr9Ts4LXVINwYbd92T36Uh9rgRFkiXUeU7uyHxF /XTijHADq/ttGFUrxSgQpgBs1exfXBxhu1fC53TX5NI0e7m821jE84gSiOkHgv1DjsCJ 42qw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id a4si805385ios.8.2021.03.04.17.50.57; Thu, 04 Mar 2021 17:51:10 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229564AbhCEBuk (ORCPT + 99 others); Thu, 4 Mar 2021 20:50:40 -0500 Received: from emcscan.emc.com.tw ([192.72.220.5]:53453 "EHLO emcscan.emc.com.tw" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229531AbhCEBuk (ORCPT ); Thu, 4 Mar 2021 20:50:40 -0500 X-IronPort-AV: E=Sophos;i="5.56,253,1539619200"; d="scan'208";a="39659207" Received: from unknown (HELO webmail.emc.com.tw) ([192.168.10.1]) by emcscan.emc.com.tw with ESMTP; 05 Mar 2021 09:50:38 +0800 Received: from 192.168.10.23 by webmail.emc.com.tw with MailAudit ESMTP Server V5.0(2833:0:AUTH_RELAY) (envelope-from ); Fri, 05 Mar 2021 09:50:37 +0800 (CST) Received: from 192.168.33.11 by webmail.emc.com.tw with Mail2000 ESMTP Server V7.00(2480:2:AUTH_RELAY) (envelope-from ); Fri, 05 Mar 2021 09:50:35 +0800 (CST) From: "jingle" To: "'Dmitry Torokhov'" Cc: "'linux-kernel'" , "'linux-input'" , "'phoenix'" , "'dave.wang'" , "'josh.chen'" References: <20210226073537.4926-1-jingle.wu@emc.com.tw> <1614647097.9201.jingle.wu@emc.com.tw> <004f01d7115e$3ba005e0$b2e011a0$@emc.com.tw> In-Reply-To: Subject: RE: [PATCH] Input: elan_i2c - Reduce the resume time for new dev ices Date: Fri, 5 Mar 2021 09:50:35 +0800 Message-ID: <005401d71161$ef9b20e0$ced162a0$@emc.com.tw> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Outlook 14.0 Thread-Index: AQGs01cKeSW+WSlGkCw6sJc3Mb/pawH5MxoQAdwxvXACK2QSBAIRtt8MAkDeqHiqdoFO8A== Content-Language: zh-tw x-dg-ref: PG1ldGE+PGF0IG5tPSJib2R5LnR4dCIgcD0iYzpcdXNlcnNcMDYwMTFcYXBwZGF0YVxyb2FtaW5nXDA5ZDg0OWI2LTMyZDMtNGE0MC04NWVlLTZiODRiYTI5ZTM1Ylxtc2dzXG1zZy0yZDM3MjQ2Ni03ZDU1LTExZWItOGUwZi1mMDc5NTk2OWU3NWVcYW1lLXRlc3RcMmQzNzI0NjgtN2Q1NS0xMWViLThlMGYtZjA3OTU5NjllNzVlYm9keS50eHQiIHN6PSIxNDMxIiB0PSIxMzI1OTM4MjYzNTkzNjg3NzQiIGg9IjBnbUVkenFod3UvUndLN003TVhReUxmVXVraz0iIGlkPSIiIGJsPSIwIiBibz0iMSIvPjwvbWV0YT4= x-dg-rorf: true Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org HI Dmitry: 1. You mean to let all devices ignore skipping reset/sleep part of device initialization? 2. The test team found that some old firmware will have errors (invalid report etc...), so ELAN can only ensure that the new device can meet the newer parts. Thanks jingle -----Original Message----- From: 'Dmitry Torokhov' [mailto:dmitry.torokhov@gmail.com] Sent: Friday, March 05, 2021 9:31 AM To: jingle Cc: 'linux-kernel'; 'linux-input'; 'phoenix'; 'dave.wang'; 'josh.chen' Subject: Re: [PATCH] Input: elan_i2c - Reduce the resume time for new dev ices Hi Jingle, On Fri, Mar 05, 2021 at 09:24:05AM +0800, jingle wrote: > HI Dmitry: > > In this case (in the newer parts behavior regarding need to reset > after powering them on), it is consistent with the original driver > behavior with any new or old device (be called > data->ops->initialize(client) : usleep(100) , etc.. , because this > times "data->quirks" is equal 0 at probe state.) You misunderstood my question. I was asking what specifically, if anything, was changed in the firmware to allow skipping reset/sleep part of device initialization on newer parts during resume process. Because of there were no specific changes I would say let's not do a quirk and change the driver to skip reset on resume. Thanks. -- Dmitry