Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp1685613pxb; Thu, 4 Mar 2021 18:47:06 -0800 (PST) X-Google-Smtp-Source: ABdhPJyOtoD5r49Hb/LJKAXquEVZsJaIwnrbQH44rmiGWwsZGGbagEzUI1GULPlcX6v+Dcm75BWl X-Received: by 2002:a02:c6b4:: with SMTP id o20mr7493758jan.124.1614912426450; Thu, 04 Mar 2021 18:47:06 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1614912426; cv=none; d=google.com; s=arc-20160816; b=glxvs8IbZUCxBWJKg2NTHK9Dnuuq5xCArmUjNvF0hJ2e7d01b89QRDsy0mhTgLjVpt prG0xYuehJYnfDOHR5DJ+vWmVdXKUyFZ5Pm7iXCJJzgF01hfdvOUHBetrw3P8tgTdG0l 8ZGp7nHli02qZQSMzHkvYBRQ80/wc7KgB+/pG6qr1814FaFhflmYs70yGpbkkwfHmJjo jtK93/Us2siHF98+nEAqfkfkezVgmyXO6/n48QkLdg+8NShqlMlqZwjTi7h2+Py6JNeg 8fpnYXVNbg6409Z3nWCcuiDOAfgztJZKsC/5OGjqx8voRSXCvEVxdW7d7Dgn5qG0hMjs pDsA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-language:content-transfer-encoding :mime-version:user-agent:date:message-id:subject:from:cc:to :dkim-signature; bh=g8rt34v65SckAVlod9EbZTGyuMV5+kTvsDcnd8tRjgU=; b=wkbyu3CfNRAkdfuxPWyWDNtFgJfDqP85ipPl1xCoZpYAzHtOW66//qlFdaMuaCxmsf lqAd/msUz5kRmI36NBTQQWkazY7YtKizmNWf3YGRZUqWWsGtc6UsVCCikw8n3p1dt2Dg Wh43Nd8+VZhD/KH2kRoVL8B2PXVmRqmAn2y2VfTMU2yUjmvogA3YwM/inFtT+SwMQLrI pBGvL17Cnr9k2MNNqwYQ2391yDuUwSsVsdH0IqIuzS0hN03i8p/7mzrXqjVRd1bqE5xc hKpQdlW7goT27NRsnDTLx7jpz62NhNECLkE2FrqghDlkzgSk/1eFlm1uuvkik28c0PqY EYlQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=tOemYn6Y; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id c5si993464jam.17.2021.03.04.18.46.27; Thu, 04 Mar 2021 18:47:06 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=tOemYn6Y; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229576AbhCECpT (ORCPT + 99 others); Thu, 4 Mar 2021 21:45:19 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52858 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229436AbhCECpS (ORCPT ); Thu, 4 Mar 2021 21:45:18 -0500 Received: from mail-pg1-x532.google.com (mail-pg1-x532.google.com [IPv6:2607:f8b0:4864:20::532]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D7351C061574; Thu, 4 Mar 2021 18:45:17 -0800 (PST) Received: by mail-pg1-x532.google.com with SMTP id x29so345797pgk.6; Thu, 04 Mar 2021 18:45:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=to:cc:from:subject:message-id:date:user-agent:mime-version :content-transfer-encoding:content-language; bh=g8rt34v65SckAVlod9EbZTGyuMV5+kTvsDcnd8tRjgU=; b=tOemYn6Yb4bld6DjuW0vMzlqxYaUizndWbIcYBb/i9wtLz22AMCFPMi6VASNcCbTLT djhSjuYkK6SxyUAOlakqOcGyr/Y4uuUXtwHjuAFryWoBPLZtuYGSQSLpy36zFrIT62qi d9UKcGPKe37PjLI5O/tT6qOfmfIhUD7q00Cc3u4/kboGzWxQo1ZCt3r3X1Kaiwe/A+Pj daIeO5erPaKyD9pB2hrBhnPl0fUiZUYGuLa7s4+Q4x7c2g/QK4/wE225pfOX7ot7dvlG S/onVoVwDswsVvU1xXi/tom1RU27CMw94gntedyodgPLk+e/lw1v5aDVJYT9H9tCGbRa uinw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:to:cc:from:subject:message-id:date:user-agent :mime-version:content-transfer-encoding:content-language; bh=g8rt34v65SckAVlod9EbZTGyuMV5+kTvsDcnd8tRjgU=; b=UqjRrFC62mZlfws1mHKrmTn4J8SHZ8L1MEeZ+4eGCTkPJ4NVsbCcMfjQiR3VZaaUPb WTJ6JTeysHM0clYA+34VV8ckjBm39LJX3JaMXnTkwrt3YMwUBJ/kxxx/I/Zltit3Lpv3 4zULyIPp/BXegfIArkqVhvW+26iAR7GeWi3b6vpJBGaGJEodA9OLQYZpcoIDZfq/UJlz h3eG+ZHwakyXPsE1gAxpuFC+tLPAq/EHfmv2rjhajtHxK0TjGLL+XKjrXub3YeK9g3Zv p8+gz0j8GM7q8MPoyYPTOedYQaQ80ENWL30DsjsIh5hsqVMSBrADUu2UK3I3965oSD6E 0rbQ== X-Gm-Message-State: AOAM533XfQwqQd/M8SdgXdvOSbR5frgnzEuQPsHqPhrUaukjZ5VMg21b sRDC9XcM7AS4ht+pTYLURYEaVTgQipLRlg== X-Received: by 2002:a63:4a1a:: with SMTP id x26mr6692573pga.260.1614912316994; Thu, 04 Mar 2021 18:45:16 -0800 (PST) Received: from [10.69.0.62] ([45.135.186.129]) by smtp.gmail.com with ESMTPSA id h6sm616095pfv.84.2021.03.04.18.45.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 04 Mar 2021 18:45:16 -0800 (PST) To: maximlevitsky@gmail.com, oakad@yahoo.com, ulf.hansson@linaro.org, trix@redhat.com Cc: linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org From: Jia-Ju Bai Subject: [BUG] memstick: core: missing error return code in msb_resume() Message-ID: <473ecf21-f0d3-9024-161e-72093004971f@gmail.com> Date: Fri, 5 Mar 2021 10:45:14 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org My static analysis tool reports that no error return code is assigned in error handling code of msb_resume(). However, many other drivers assign error return code in xxx_resume(), such as sky2_resume() and e1000_resume(). I wonder whether this is intentional? Best wishes, Jia-Ju Bai