Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp1740780pxb; Thu, 4 Mar 2021 21:01:02 -0800 (PST) X-Google-Smtp-Source: ABdhPJxYsqj1pCG7EQelpRrOXG825n15D8xjuXs9vEx4jzZHyQ5yxbZ1pEp0TpLSQ4LNp6QxXMMD X-Received: by 2002:aa7:d94c:: with SMTP id l12mr7240330eds.311.1614920462295; Thu, 04 Mar 2021 21:01:02 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1614920462; cv=none; d=google.com; s=arc-20160816; b=zWMJyLFaJBZzItYy0TBuJ3SnSfu5hpre3qQZBO/YGbrzU9v4Gu3bMr1Cvry5r+Fmm6 dU0WUnS3FfezFK8FwIMM34xHldRbMQbV5PaxYm7XowfUOkzL8drKiAafwW8xHq2Ojeu9 9Rn/f6lGQ6PeMR+1n+t4XyFKk0KXIX7kWU3kU9vDM9K3T3U2IQrJLNudkQ2DgExrbKHs cgJjBeLwFmtcors34jfXX/70RFPusrEBooOTi8GiRXFk7ZoqCEXeO/l+cHrrCe1s3BvH XmxhwM9ZLvWj/8t837pxZia7uKYeNWSQNcvwaoVMAEKig6Iesiq2/4zCV0kNgiF8TZZq iK0g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=g0Mk72avpHdhSJAjqBV5Yll3WvB1xqe8t3SVT3h8H5k=; b=FBv5ld1dC5HM3xwAY5cvJxfhHr9eZJGwUqciRpZnVVOsmSC5FUiQ4Cf/kYRvhWdiAM e3vbANNbCgDxKs3iMz7ZfhvZFmiYh+Cts/tn/NGf4nXcVcyGmAOwhTX6Xi93a8pJc18u my4/d/BiuBMhFP1OXwvQBSd4SSb3X9BtBwtSMEqKB0/tScw42Ph/O9yr8DGUasNEmE5J CFQe5v8/PFpkc0D+ILnyDGb1SWxVmLiX2AYJpavmJansQRcN1Ky2dmyJ91kDNmvXp4RX DNDVNXClE/7OuU93mKoSKG+6e0guxz4Q3IWl44IQZDH2C6RA+QjjjQqVAoj+WLE5Afdx eiTw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=CI9w0x4S; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id p17si1048226edq.210.2021.03.04.21.00.38; Thu, 04 Mar 2021 21:01:02 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=CI9w0x4S; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229512AbhCEE7t (ORCPT + 99 others); Thu, 4 Mar 2021 23:59:49 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53428 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229463AbhCEE7s (ORCPT ); Thu, 4 Mar 2021 23:59:48 -0500 Received: from mail-ot1-x32c.google.com (mail-ot1-x32c.google.com [IPv6:2607:f8b0:4864:20::32c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 81C45C061574; Thu, 4 Mar 2021 20:59:48 -0800 (PST) Received: by mail-ot1-x32c.google.com with SMTP id v12so624290ott.10; Thu, 04 Mar 2021 20:59:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=g0Mk72avpHdhSJAjqBV5Yll3WvB1xqe8t3SVT3h8H5k=; b=CI9w0x4SKtGImgBFfj3etYWLTG9vsxvaMEKVO9F8GmvkuYUUwkJyLXahEl/PpwnIXX 4orQ0SHxLHw0+CtH2+vJNdD3np6x0FAywYPKM1jiusFpC546N3cofuwUlLOM9kE84lYo Sm01CW3imaRgyg4tN8HZExpfGfII5+itgs396aV88zF7D5dnHC20Kaels8rsA05eIvJL ehSUBPHrO9v85hNGXlmVS6rzOpaU90fOcjdNsbiUBDL+SopPnNDkKKPUkD39fAf/ReOv Sn3yv17JytDJ0bmDx3osG8r3vL4gCAXNrMD7zra1z4Fz0Ams2upy8kGO/eQ3Tcy4WJxa GIIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=g0Mk72avpHdhSJAjqBV5Yll3WvB1xqe8t3SVT3h8H5k=; b=SRtaDWik+JV4SsRQmUa3l4LZ7O0hjKcMPfDlg+chj/8ppO2lE11QUUSQsF6rpGpjXA mzax3iVJG+kdYXt28Ddo6ScL1C0KAHLsgRvgsbujijur+xWPxv7kvWR7c6mdcU6ulY/S cmxGDbmAYUxLW+ZSJtz5n17tv+z/JBJDhuMtbymxdYfQldTIg+pq+psTDQFz3SwcekyL 5uwjgeZGrACwnxTN4AApKANZ6z6TB7wez3H4E/HVMPokXRmnVZ0V1IK9h2jrXKPpRZkK 7RsGoLNOiHbfKHjz4u1wZP/CCKhsRP0w0Xm7V6oJbqy3MnmU8MQa+I5wbzhJOVm0D8pM dJpw== X-Gm-Message-State: AOAM533B6U+zIvk/avikGNvFIV+zOsswm4s+laoGga9/tZQVVDSh8jWx 4jwnyAuScBgpdnScAuhsqVVL1e7NIEmumQ5eakw= X-Received: by 2002:a9d:6e01:: with SMTP id e1mr6552620otr.74.1614920387915; Thu, 04 Mar 2021 20:59:47 -0800 (PST) MIME-Version: 1.0 References: <20210305034931.3237558-1-weiyongjun1@huawei.com> In-Reply-To: <20210305034931.3237558-1-weiyongjun1@huawei.com> From: Sergio Paracuellos Date: Fri, 5 Mar 2021 05:59:36 +0100 Message-ID: Subject: Re: [PATCH -next] phy: ralink: phy-mt7621-pci: fix return value check in mt7621_pci_phy_probe() To: "'Wei Yongjun" Cc: Kishon Vijay Abraham I , Vinod Koul , Matthias Brugger , linux-phy@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel , kernel-janitors@vger.kernel.org, Hulk Robot Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Mar 5, 2021 at 4:40 AM 'Wei Yongjun wrote: > > From: Wei Yongjun > > Fix the return value check which testing the wrong variable > in mt7621_pci_phy_probe(). > > Fixes: d87da32372a0 ("phy: ralink: Add PHY driver for MT7621 PCIe PHY") > Reported-by: Hulk Robot > Signed-off-by: Wei Yongjun > --- > drivers/phy/ralink/phy-mt7621-pci.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Sergio Paracuellos