Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 4 Mar 2021 23:14:03 -0600
From:   Nishanth Menon <nm@ti.com>
To:     Kishon Vijay Abraham I <kishon@ti.com>
CC:     Aswath Govindraju <a-govindraju@ti.com>,
        Vignesh Raghavendra <vigneshr@ti.com>,
        Lokesh Vutla <lokeshvutla@ti.com>,
        Grygorii Strashko <grygorii.strashko@ti.com>,
        Tero Kristo <kristo@kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        Faiz Abbas <faiz_abbas@ti.com>,
        <linux-arm-kernel@lists.infradead.org>,
        <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] arm64: dts: ti: k3-j721e-main: Update the speed modes
 supported and their itap delay values for MMCSD subsystems
Message-ID: <20210305051403.y4lzv5woisimzlgb@persuader>
References: <20210225132736.26429-1-a-govindraju@ti.com>
 <969c38e2-01e8-55a1-b97e-cf72f07fcd62@ti.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <969c38e2-01e8-55a1-b97e-cf72f07fcd62@ti.com>
User-Agent: NeoMutt/20171215
Precedence: bulk

On 10:59-20210301, Kishon Vijay Abraham I wrote:
> On 25/02/21 6:57 pm, Aswath Govindraju wrote:
> > According to latest errata of J721e [1], HS400 mode is not supported
> > in MMCSD0 subsystem (i2024) and SDR104 mode is not supported in MMCSD1/2
> > subsystems (i2090). Therefore, replace mmc-hs400-1_8v with mmc-hs200-1_8v
> > in MMCSD0 subsystem and add a sdhci mask to disable SDR104 speed mode.
> > 
> > Also, update the itap delay values for all the MMCSD subsystems according
> > the latest J721e data sheet[2]
> > 
> > [1] - https://www.ti.com/lit/er/sprz455/sprz455.pdf
> > [2] - https://www.ti.com/lit/ds/symlink/tda4vm.pdf
> > 
> > Fixes: e6dc10f200da ("arm64: dts: ti: j721e-main: Add SDHCI nodes")
> > Signed-off-by: Aswath Govindraju <a-govindraju@ti.com>
> 
> Reviewed-by: Kishon Vijay Abraham I <kishon@ti.com>


In some offline testing, I realized that the patch wont apply cleanly to e6dc10f200da

cd48ce86a4d0c1ffec86aa46a26da993c9af5f53 might be a better candidate for
this - I will drop the patch from my queue in the morning, could you
update the patch with a new rev with appropriate Fixes?
-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D)/Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D