Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Pawel Laszczak <pawell@cadence.com>
To:     Pawel Laszczak <pawell@cadence.com>,
        "peter.chen@nxp.com" <peter.chen@nxp.com>
CC:     "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
        "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Rahul Kumar <kurahul@cadence.com>,
        Sanket Parmar <sparmar@cadence.com>
Subject: RE: [PATCH] usb: cdnsp: Fixes incorrect value in ISOC TRB
Thread-Topic: [PATCH] usb: cdnsp: Fixes incorrect value in ISOC TRB
Thread-Index: AQHXEXyK1z6qTwgDjEORzPSt+8Yoy6p02Y1w
Date:   Fri, 5 Mar 2021 05:16:13 +0000
Message-ID: <BYAPR07MB53818D48E6D3EBBC05034B96DD969@BYAPR07MB5381.namprd07.prod.outlook.com>
References: <20210305050028.3329-1-pawell@gli-login.cadence.com>
In-Reply-To: <20210305050028.3329-1-pawell@gli-login.cadence.com>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 0911ca89-98f2-4d0c-34b0-08d8df95cc05
X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Mar 2021 05:16:13.7730
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: d36035c5-6ce6-4662-a3dc-e762e61ae4c9
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: Va81YvnPXVuFQAS6D5CC0z6nS0AULMOfecZ7GQHLw8L4JjSZg25cxfk8+1MmWNOYoNYHm5dJMcovjFq+cJ6nVzBGzgjpUKlqzGNVeCSXwns=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR07MB7944
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.369,18.0.761
 definitions=2021-03-05_03:2021-03-03,2021-03-05 signatures=0
X-Proofpoint-Spam-Details: rule=outbound_check_notspam policy=outbound_check score=0 bulkscore=0
 clxscore=1015 adultscore=0 impostorscore=0 mlxlogscore=999 mlxscore=0
 lowpriorityscore=0 spamscore=0 phishscore=0 priorityscore=1501
 malwarescore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx
 scancount=1 engine=8.12.0-2009150000 definitions=main-2103050024
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi,

Please ignore this patch. I put incorrect address to Peter. I have sent aga=
in this patch with correct email address.

>-----Original Message-----
>From: Pawel Laszczak <pawell@cadence.com>
>Sent: Friday, March 5, 2021 6:00 AM
>To: peter.chen@nxp.com
>Cc: gregkh@linuxfoundation.org; linux-usb@vger.kernel.org; linux-kernel@vg=
er.kernel.org; Rahul Kumar <kurahul@cadence.com>;
>Sanket Parmar <sparmar@cadence.com>; Pawel Laszczak <pawell@cadence.com>
>Subject: [PATCH] usb: cdnsp: Fixes incorrect value in ISOC TRB
>
>From: Pawel Laszczak <pawell@cadence.com>
>
>The value "start_cycle ? 0 : 1" in assignment caused
>implicit truncation whole value to 1 byte.
>To fix the issue, an explicit casting has been added.
>
>Fixes: commit 3d82904559f4 ("usb: cdnsp: cdns3 Add main part of Cadence US=
BSSP DRD Driver")
>Signed-off-by: Pawel Laszczak <pawell@cadence.com>
>---
> drivers/usb/cdns3/cdnsp-ring.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/drivers/usb/cdns3/cdnsp-ring.c b/drivers/usb/cdns3/cdnsp-ring=
.c
>index f9170d177a89..d35bc4490216 100644
>--- a/drivers/usb/cdns3/cdnsp-ring.c
>+++ b/drivers/usb/cdns3/cdnsp-ring.c
>@@ -2197,7 +2197,7 @@ static int cdnsp_queue_isoc_tx(struct cdnsp_device *=
pdev,
> 	 * inverted in the first TDs isoc TRB.
> 	 */
> 	field =3D TRB_TYPE(TRB_ISOC) | TRB_TLBPC(last_burst_pkt) |
>-		start_cycle ? 0 : 1 | TRB_SIA | TRB_TBC(burst_count);
>+		(u32)(start_cycle ? 0 : 1) | TRB_SIA | TRB_TBC(burst_count);
>
> 	/* Fill the rest of the TRB fields, and remaining normal TRBs. */
> 	for (i =3D 0; i < trbs_per_td; i++) {
>--
>2.25.1

Regards,
Pawel Laszczak