Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp1830016pxb; Fri, 5 Mar 2021 00:14:07 -0800 (PST) X-Google-Smtp-Source: ABdhPJz1yGfkivy54D7h0KOreq/JhaPUQUCGsVtxk0mUedjJfy6hGAb/PqGgVUAo5DBO8cBoDc8n X-Received: by 2002:aa7:da48:: with SMTP id w8mr7845408eds.81.1614932047012; Fri, 05 Mar 2021 00:14:07 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1614932047; cv=none; d=google.com; s=arc-20160816; b=t704C5zCz8K/dLRO5VcBK55CRDpHnHUYAcfmWZwUdhsZsxMWFYiSrEap22Tchj+cPS OcUdTZC0OqCuSPV0Qmd7MuVJBKNGfL7fftzXWxlnKPez0WaVCl84VzdaVpwhEe8sWUrG oKmghvzQ7D4bHuuw06v2Q2TdvsKngYB0Zg8jQYkuJlsIkFRNCEQpyqK9PfRrDTWUG4Gk NRXik59LYQypzhoEAS5jBvTH2DDI7fZO43Pt89LxkJQrY3AdaBxO9nvZqc7YK7V8IHhN fn8uwRc5yyVy0LaOv4HRF1XoxnG0zeqhaXQG0tRO2Hbdxtsp9qE8k7tVM6++Xhihwkmb wurw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=qzDw47z9cmcIPC1rW9QLd8oJb6CmtII1SB7vSsEPO4U=; b=AXqnZdByFdRn3gj1QLl7Fl/2hN1TZIY7RSOgAYlLIWLDTlPOGe8rdNSN6Py27f5PZ7 +dF2TpWEjt/6yvtRaVag6AJ5L5dItCu5bDdYQOT4OnH54pYH3Ne0R17eQcg4Ql86kNxn gve3ZKhtkJ4xeyrh6EaHSPK1kPRW31cehPTWN4ei/LNI7HfJCNdfLDFCxkTb7ohsGCfq bO6NO9/oaF4lZxUKzLA+4ZUTbvwzmA0g+Vpw7KlAQeqx3xlN9/JGNA0DaTidcZVdKuOw 3oan6Rq4COrMZnjRH3kjLQf83MRiXkp2BsecuTgjYlosOozTtsz4UI24LetE3+DgzuaY /wZg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id m12si1156634eds.183.2021.03.05.00.13.44; Fri, 05 Mar 2021 00:14:07 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229591AbhCEINF (ORCPT + 99 others); Fri, 5 Mar 2021 03:13:05 -0500 Received: from mail-lj1-f179.google.com ([209.85.208.179]:37168 "EHLO mail-lj1-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229520AbhCEINA (ORCPT ); Fri, 5 Mar 2021 03:13:00 -0500 Received: by mail-lj1-f179.google.com with SMTP id q14so1669246ljp.4 for ; Fri, 05 Mar 2021 00:12:59 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=qzDw47z9cmcIPC1rW9QLd8oJb6CmtII1SB7vSsEPO4U=; b=E24ru7F1FQPe6EEOhFfMAXDrjiWQEwuwiBUwLp+zwnFO+O5CCmqBFgYDY19GZh0Pat ZOJldcXQx8XAXn7A0F5K80Th5N2DumknMkfbl4u+5m/tdOoDP766Vvt6nCNl+ojxFK+6 Ncx4Rx0K7RnzV+Ojo5QQeQQ9+Oo8HKUpsCz0efPQoI4suretqPSDrLrehZ6uDLqUmB4D nh2P1gb454/2pfQYfRIQqST+PQRtETtM7Li0Pkg4EKq/fxYh5IYsyrCZRp8YqGhILc2l MNkHyKn1RbN0E2zB5ZPAhsS9cklUyKz0LYEJAwTuQToISt1shsbTty2rehXywXsCz9sC cFqA== X-Gm-Message-State: AOAM531oto/cFfXKXScbIGJ7t3MM6YixeJJNusfeZoJF1dVBkzSfDvGb EOSvkHtSbjU22xlW9N1TzEU= X-Received: by 2002:a2e:9595:: with SMTP id w21mr4584541ljh.72.1614931979242; Fri, 05 Mar 2021 00:12:59 -0800 (PST) Received: from localhost.. (broadband-188-32-236-56.ip.moscow.rt.ru. [188.32.236.56]) by smtp.googlemail.com with ESMTPSA id u13sm209651lfr.124.2021.03.05.00.12.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Mar 2021 00:12:58 -0800 (PST) From: Denis Efremov To: Julia Lawall Cc: Denis Efremov , cocci@systeme.lip6.fr, linux-kernel@vger.kernel.org Subject: [PATCH v3] coccinelle: misc: add swap script Date: Fri, 5 Mar 2021 13:09:56 +0300 Message-Id: <20210305100956.6222-1-efremov@linux.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210216080133.455456-1-efremov@linux.com> References: <20210216080133.455456-1-efremov@linux.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Check for opencoded swap() implementation. Signed-off-by: Denis Efremov --- Changes in v2: - additional patch rule to drop excessive {} - fix indentation in patch mode by anchoring ; Changes in v3: - Rule added for simple (without var init) swap highlighting in !patch mode - "depends on patch && (rpvar || rp)" fixed scripts/coccinelle/misc/swap.cocci | 122 +++++++++++++++++++++++++++++ 1 file changed, 122 insertions(+) create mode 100644 scripts/coccinelle/misc/swap.cocci diff --git a/scripts/coccinelle/misc/swap.cocci b/scripts/coccinelle/misc/swap.cocci new file mode 100644 index 000000000000..c5e71b7ef7f5 --- /dev/null +++ b/scripts/coccinelle/misc/swap.cocci @@ -0,0 +1,122 @@ +// SPDX-License-Identifier: GPL-2.0-only +/// +/// Check for opencoded swap() implementation. +/// +// Confidence: High +// Copyright: (C) 2021 Denis Efremov ISPRAS +// Options: --no-includes --include-headers +// +// Keywords: swap +// + +virtual patch +virtual org +virtual report +virtual context + +@rvar depends on !patch@ +identifier tmp; +expression a, b; +type T; +position p; +@@ + +( +* T tmp; +| +* T tmp = 0; +| +* T *tmp = NULL; +) +... when != tmp +* tmp = a; +* a = b;@p +* b = tmp; +... when != tmp + +@r depends on !patch@ +identifier tmp; +expression a, b; +position p != rvar.p; +@@ + +* tmp = a; +* a = b;@p +* b = tmp; + +@rpvar depends on patch@ +identifier tmp; +expression a, b; +type T; +@@ + +( +- T tmp; +| +- T tmp = 0; +| +- T *tmp = NULL; +) +... when != tmp +- tmp = a; +- a = b; +- b = tmp ++ swap(a, b) + ; +... when != tmp + +@rp depends on patch@ +identifier tmp; +expression a, b; +@@ + +- tmp = a; +- a = b; +- b = tmp ++ swap(a, b) + ; + +@depends on patch && (rpvar || rp)@ +@@ + +( + for (...;...;...) +- { + swap(...); +- } +| + while (...) +- { + swap(...); +- } +| + if (...) +- { + swap(...); +- } +) + + +@script:python depends on report@ +p << r.p; +@@ + +coccilib.report.print_report(p[0], "WARNING opportunity for swap()") + +@script:python depends on org@ +p << r.p; +@@ + +coccilib.org.print_todo(p[0], "WARNING opportunity for swap()") + +@script:python depends on report@ +p << rvar.p; +@@ + +coccilib.report.print_report(p[0], "WARNING opportunity for swap()") + +@script:python depends on org@ +p << rvar.p; +@@ + +coccilib.org.print_todo(p[0], "WARNING opportunity for swap()") -- 2.26.2