Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v8 3/3] perf vendor events arm64: Add "_" to the event
 name, which starts with a number
To:     Shunsuke Nakamura <nakamura.shun@fujitsu.com>, <will@kernel.org>,
        <mathieu.poirier@linaro.org>, <leo.yan@linaro.org>,
        <peterz@infradead.org>, <mingo@redhat.com>, <acme@kernel.org>,
        <mark.rutland@arm.com>, <alexander.shishkin@linux.intel.com>,
        <jolsa@redhat.com>, <namhyung@kernel.org>
CC:     <linux-arm-kernel@lists.infradead.org>,
        <linux-kernel@vger.kernel.org>
References: <20210305101841.3133721-1-nakamura.shun@fujitsu.com>
 <20210305101841.3133721-4-nakamura.shun@fujitsu.com>
From:   John Garry <john.garry@huawei.com>
Message-ID: <b140182c-3250-8c28-c28a-9dc3cefc89a2@huawei.com>
Date:   Fri, 5 Mar 2021 11:09:20 +0000
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101
 Thunderbird/68.1.2
MIME-Version: 1.0
In-Reply-To: <20210305101841.3133721-4-nakamura.shun@fujitsu.com>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 05/03/2021 10:18, Shunsuke Nakamura wrote:
> The perf parser does not support event names that start with a number.
> This patch adds "_" to the event name, which starts with a number.
> 
> Signed-off-by: Shunsuke Nakamura <nakamura.shun@fujitsu.com>

I think that this can be folded into patch 2/3, and my reveiwed-by tag 
still stands for patch 2/3.

Thanks

> ---
>   .../pmu-events/arch/arm64/fujitsu/a64fx/other.json     | 10 +++++-----
>   1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/tools/perf/pmu-events/arch/arm64/fujitsu/a64fx/other.json b/tools/perf/pmu-events/arch/arm64/fujitsu/a64fx/other.json
> index 68b8e46d6140..10c823ac26cc 100644
> --- a/tools/perf/pmu-events/arch/arm64/fujitsu/a64fx/other.json
> +++ b/tools/perf/pmu-events/arch/arm64/fujitsu/a64fx/other.json
> @@ -98,31 +98,31 @@
>     {
>       "PublicDescription": "This event counts every cycle that no instruction was committed, but counts at the time when commits MOVPRFX only.",
>       "EventCode": "0x190",
> -    "EventName": "0INST_COMMIT",
> +    "EventName": "_0INST_COMMIT",
>       "BriefDescription": "This event counts every cycle that no instruction was committed, but counts at the time when commits MOVPRFX only."
>     },
>     {
>       "PublicDescription": "This event counts every cycle that one instruction is committed.",
>       "EventCode": "0x191",
> -    "EventName": "1INST_COMMIT",
> +    "EventName": "_1INST_COMMIT",
>       "BriefDescription": "This event counts every cycle that one instruction is committed."
>     },
>     {
>       "PublicDescription": "This event counts every cycle that two instructions are committed.",
>       "EventCode": "0x192",
> -    "EventName": "2INST_COMMIT",
> +    "EventName": "_2INST_COMMIT",
>       "BriefDescription": "This event counts every cycle that two instructions are committed."
>     },
>     {
>       "PublicDescription": "This event counts every cycle that three instructions are committed.",
>       "EventCode": "0x193",
> -    "EventName": "3INST_COMMIT",
> +    "EventName": "_3INST_COMMIT",
>       "BriefDescription": "This event counts every cycle that three instructions are committed."
>     },
>     {
>       "PublicDescription": "This event counts every cycle that four instructions are committed.",
>       "EventCode": "0x194",
> -    "EventName": "4INST_COMMIT",
> +    "EventName": "_4INST_COMMIT",
>       "BriefDescription": "This event counts every cycle that four instructions are committed."
>     },
>     {
>