Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 5 Mar 2021 12:32:08 +0100
From:   Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= <u.kleine-koenig@pengutronix.de>
To:     Tong Zhang <ztong0001@gmail.com>
Cc:     Wolfgang Grandegger <wg@grandegger.com>,
        Marc Kleine-Budde <mkl@pengutronix.de>,
        "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        Vincent Mailhol <mailhol.vincent@wanadoo.fr>,
        Oliver Hartkopp <socketcan@hartkopp.net>,
        YueHaibing <yuehaibing@huawei.com>,
        Zhang Qilong <zhangqilong3@huawei.com>,
        linux-can@vger.kernel.org, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] can: c_can: move runtime PM enable/disable to
 c_can_platform
Message-ID: <20210305113208.3wm6fvqeunut2yci@pengutronix.de>
References: <20210301150840.mqngl7og46o3nxjb@pengutronix.de>
 <20210302025542.987600-1-ztong0001@gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="tedc23qcg7ntrk2r"
Content-Disposition: inline
In-Reply-To: <20210302025542.987600-1-ztong0001@gmail.com>
Precedence: bulk


--tedc23qcg7ntrk2r
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Mar 01, 2021 at 09:55:40PM -0500, Tong Zhang wrote:
> Currently doing modprobe c_can_pci will make kernel complain
> "Unbalanced pm_runtime_enable!", this is caused by pm_runtime_enable()
> called before pm is initialized.
> This fix is similar to 227619c3ff7c, move those pm_enable/disable code to
> c_can_platform.

I can confirm this makes the warning go away on a Congatec Atom board. I
didn't do any further runtime tests.

Tested-by: Uwe Kleine-K=F6nig <u.kleine-koenig@pengutronix.de>

Thanks
Uwe

--=20
Pengutronix e.K.                           | Uwe Kleine-K=F6nig            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

--tedc23qcg7ntrk2r
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEfnIqFpAYrP8+dKQLwfwUeK3K7AkFAmBCFrUACgkQwfwUeK3K
7AkanQf9G3uCIVa8WjFfyEnHR5Odw85asNQY6UqEntHOLnR5zslZrVtjknyTXj4I
O5tWJ1mB4l5n4Aqje5lHIHKTrkW8bx4kGBfAl94YxfPK6hjDlLivmL/SjHJB1C+t
UUBuVLAu23ay580qX7YRcOIh3PTK+URXQcZwQCu3TlVe4s3SUl+fMKU8CeKVpvEr
q03UFaTgoM5rVKqg54zI9V+NkHJHcABw/fCxsXo204ZLSeCJckjxHvNWSG1uPlvZ
9BaGRMYn87+bMOdMOAEFtz85WagHS9fKl/BW2FeOCY/1q+dcJJSKUkr5RWr2qyHD
Wb/nFrcn1fgjNYASlbFEO3glnLiBWw==
=yGiz
-----END PGP SIGNATURE-----

--tedc23qcg7ntrk2r--