Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH net] r8169: fix r8168fp_adjust_ocp_cmd function
To:     Hayes Wang <hayeswang@realtek.com>
Cc:     nic_swsd@realtek.com, linux-kernel@vger.kernel.org,
        netdev@vger.kernel.org
References: <1394712342-15778-348-Taiwan-albertk@realtek.com>
From:   Heiner Kallweit <hkallweit1@gmail.com>
Message-ID: <46815c59-9eb0-8324-1ff3-df42cd95fdd3@gmail.com>
Date:   Fri, 5 Mar 2021 12:48:18 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.8.0
MIME-Version: 1.0
In-Reply-To: <1394712342-15778-348-Taiwan-albertk@realtek.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 05.03.2021 10:34, Hayes Wang wrote:
> The (0xBAF70000 & 0x00FFF000) << 6 should be (0xf70 << 18).
> 
> Fixes: 561535b0f239 ("r8169: fix OCP access on RTL8117")
> Signed-off-by: Hayes Wang <hayeswang@realtek.com>
> ---
>  drivers/net/ethernet/realtek/r8169_main.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/realtek/r8169_main.c b/drivers/net/ethernet/realtek/r8169_main.c
> index f704da3f214c..7aad0ba53372 100644
> --- a/drivers/net/ethernet/realtek/r8169_main.c
> +++ b/drivers/net/ethernet/realtek/r8169_main.c
> @@ -767,7 +767,7 @@ static void r8168fp_adjust_ocp_cmd(struct rtl8169_private *tp, u32 *cmd, int typ
>  	if (type == ERIAR_OOB &&
>  	    (tp->mac_version == RTL_GIGA_MAC_VER_52 ||
>  	     tp->mac_version == RTL_GIGA_MAC_VER_53))
> -		*cmd |= 0x7f0 << 18;
> +		*cmd |= 0xf70 << 18;
>  }
>  
>  DECLARE_RTL_COND(rtl_eriar_cond)
> 
Acked-by: Heiner Kallweit <hkallweit1@gmail.com>