Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp1975003pxb; Fri, 5 Mar 2021 04:33:23 -0800 (PST) X-Google-Smtp-Source: ABdhPJyWNP2UcgLJCAxy1k/JTxtuOLe6iiRGdLr3nR9W6dnatM6BxZ8GM5FE7zk4yUSs+sS8btOY X-Received: by 2002:aa7:d686:: with SMTP id d6mr9099571edr.146.1614947602822; Fri, 05 Mar 2021 04:33:22 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1614947602; cv=none; d=google.com; s=arc-20160816; b=UGFtlQE30urb8RiMVa8LKcww/XTakqZxWRCdj/4GVvS0r4RonON77ZabVLrwe5uYdd RRmVSxR5SY21BH0NpyX/S7QUY82XqZN3J/JujQHqwr/rP/wYIlRr0yOEUuGuxzV3gMYJ pDZF1Q93K5B6sOO/se8AwiX27stru5uxqIOgy+dC1BzQzDP9QmxfvcoOVrHLx2bK3eCr XilQzYCjYJ9MTFYTLG5aJJRBTztfMmVYMCcj4eT2CFfFUA9TBNfmeX7rIUKE0IeqiSh2 +74loV7j+N8Y8zDvxWM01Ijd0OXMH8aAwOH354Yl4+q7wQ18D76vWMsnwB1l6TqDDvBW O7DA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=YZ+MXcLY0cQbnDr107y8pIcdbfywkOtyb+VjmOs7gRY=; b=IdMx9GAU2oTtfAicOuoFoTj6JB17qkRTQ+J9wllsJoXAa0rMiodcSXGNmj2c/BngvY LfK0ZWhoBOJK8XwJRpnlj4ihOfIsc+EeuirVPaMSacQ767IY8qhxb7LfAHMx46UqcZ2D m0e/v4/iTPw3QKApSSfXSmBHPrz61uFKbuvfmmtNtym0eli4VY+FvUSYbAkwNHNZ/gyB KggYOrjq19yg7hwncGc1gHY/fVnONydtTHmSmgeYlsniYxQpO86XJ7wbFodZU+vmXy/s t4mu6keeR83pxEM8DXzwZrwB4Opp7N2+XEH873tKasMR7EOO+6NlJfAjmbIPy5Sx7/gg VIkw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=pEe7NHVq; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id n2si1278337ejy.130.2021.03.05.04.32.59; Fri, 05 Mar 2021 04:33:22 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=pEe7NHVq; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232007AbhCEM2g (ORCPT + 99 others); Fri, 5 Mar 2021 07:28:36 -0500 Received: from mail.kernel.org ([198.145.29.99]:36674 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231921AbhCEM2F (ORCPT ); Fri, 5 Mar 2021 07:28:05 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 227F165031; Fri, 5 Mar 2021 12:28:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1614947284; bh=ejXKRYZG76XwBu6KMXOnU+pRL099t+/SP1QHHv8cDH4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=pEe7NHVq6ZOXihvprIAhivUlRi0t001lRa/h9zWdxC3zGGY/u/H6U2gFiASS49BMm z9oXr6II2SuXs1XZvXiAyUwXnm3iI2U7zXOOUR68X8rqvmzFl2Q1SPbD8BD974fev+ 7pJiibxEk/3oi7vSp2WsWcz7mifG/ex0KDMUmvRc= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Jingle Wu , Dmitry Torokhov , Nikolai Kostrigin Subject: [PATCH 5.10 003/102] Input: elan_i2c - add new trackpoint report type 0x5F Date: Fri, 5 Mar 2021 13:20:22 +0100 Message-Id: <20210305120903.456291523@linuxfoundation.org> X-Mailer: git-send-email 2.30.1 In-Reply-To: <20210305120903.276489876@linuxfoundation.org> References: <20210305120903.276489876@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Jingle Wu commit 056115daede8d01f71732bc7d778fb85acee8eb6 upstream. The 0x5F is a new trackpoint report type used by some modules. Signed-off-by: Jingle Wu Link: https://lore.kernel.org/r/20201211071511.32349-1-jingle.wu@emc.com.tw Signed-off-by: Dmitry Torokhov Cc: Nikolai Kostrigin Signed-off-by: Greg Kroah-Hartman --- drivers/input/mouse/elan_i2c.h | 16 ++++++++++++++++ drivers/input/mouse/elan_i2c_core.c | 13 +------------ drivers/input/mouse/elan_i2c_smbus.c | 8 ++++++-- 3 files changed, 23 insertions(+), 14 deletions(-) --- a/drivers/input/mouse/elan_i2c.h +++ b/drivers/input/mouse/elan_i2c.h @@ -28,6 +28,22 @@ #define ETP_FEATURE_REPORT_MK BIT(0) +#define ETP_REPORT_ID 0x5D +#define ETP_TP_REPORT_ID 0x5E +#define ETP_TP_REPORT_ID2 0x5F +#define ETP_REPORT_ID2 0x60 /* High precision report */ + +#define ETP_REPORT_ID_OFFSET 2 +#define ETP_TOUCH_INFO_OFFSET 3 +#define ETP_FINGER_DATA_OFFSET 4 +#define ETP_HOVER_INFO_OFFSET 30 +#define ETP_MK_DATA_OFFSET 33 /* For high precision reports */ + +#define ETP_MAX_REPORT_LEN 39 + +#define ETP_MAX_FINGERS 5 +#define ETP_FINGER_DATA_LEN 5 + /* IAP Firmware handling */ #define ETP_PRODUCT_ID_FORMAT_STRING "%d.0" #define ETP_FW_NAME "elan_i2c_" ETP_PRODUCT_ID_FORMAT_STRING ".bin" --- a/drivers/input/mouse/elan_i2c_core.c +++ b/drivers/input/mouse/elan_i2c_core.c @@ -47,18 +47,6 @@ #define ETP_FINGER_WIDTH 15 #define ETP_RETRY_COUNT 3 -#define ETP_MAX_FINGERS 5 -#define ETP_FINGER_DATA_LEN 5 -#define ETP_REPORT_ID 0x5D -#define ETP_REPORT_ID2 0x60 /* High precision report */ -#define ETP_TP_REPORT_ID 0x5E -#define ETP_REPORT_ID_OFFSET 2 -#define ETP_TOUCH_INFO_OFFSET 3 -#define ETP_FINGER_DATA_OFFSET 4 -#define ETP_HOVER_INFO_OFFSET 30 -#define ETP_MK_DATA_OFFSET 33 /* For high precision reports */ -#define ETP_MAX_REPORT_LEN 39 - /* The main device structure */ struct elan_tp_data { struct i2c_client *client; @@ -1076,6 +1064,7 @@ static irqreturn_t elan_isr(int irq, voi elan_report_absolute(data, report, true); break; case ETP_TP_REPORT_ID: + case ETP_TP_REPORT_ID2: elan_report_trackpoint(data, report); break; default: --- a/drivers/input/mouse/elan_i2c_smbus.c +++ b/drivers/input/mouse/elan_i2c_smbus.c @@ -45,6 +45,7 @@ #define ETP_SMBUS_CALIBRATE_QUERY 0xC5 #define ETP_SMBUS_REPORT_LEN 32 +#define ETP_SMBUS_REPORT_LEN2 7 #define ETP_SMBUS_REPORT_OFFSET 2 #define ETP_SMBUS_HELLOPACKET_LEN 5 #define ETP_SMBUS_IAP_PASSWORD 0x1234 @@ -497,10 +498,13 @@ static int elan_smbus_get_report(struct return len; } - if (len != ETP_SMBUS_REPORT_LEN) { + if (report[ETP_REPORT_ID_OFFSET] == ETP_TP_REPORT_ID2) + report_len = ETP_SMBUS_REPORT_LEN2; + + if (len != report_len) { dev_err(&client->dev, "wrong report length (%d vs %d expected)\n", - len, ETP_SMBUS_REPORT_LEN); + len, report_len); return -EIO; }