Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 5 Mar 2021 13:52:41 +0000
From:   Qais Yousef <qais.yousef@arm.com>
To:     Vincent Guittot <vincent.guittot@linaro.org>
Cc:     mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com,
        dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com,
        mgorman@suse.de, bristot@redhat.com, linux-kernel@vger.kernel.org,
        joel@joelfernandes.org, valentin.schneider@arm.com,
        fweisbec@gmail.com, tglx@linutronix.de
Subject: Re: [PATCH 6/7 v4] sched/fair: trigger the update of blocked load on
 newly idle cpu
Message-ID: <20210305135241.ftnxhktb6ix5qkk5@e107158-lin.cambridge.arm.com>
References: <20210224133007.28644-1-vincent.guittot@linaro.org>
 <20210224133007.28644-7-vincent.guittot@linaro.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20210224133007.28644-7-vincent.guittot@linaro.org>
Precedence: bulk

On 02/24/21 14:30, Vincent Guittot wrote:
> +/*
> + * Check if we need to run the ILB for updating blocked load before entering
> + * idle state.
> + */
> +void nohz_run_idle_balance(int cpu)
> +{
> +	unsigned int flags;
> +
> +	flags = atomic_fetch_andnot(NOHZ_NEWILB_KICK, nohz_flags(cpu));
> +
> +	/*
> +	 * Update the blocked load only if no SCHED_SOFTIRQ is about to happen
> +	 * (ie NOHZ_STATS_KICK set) and will do the same.
> +	 */
> +	if ((flags == NOHZ_NEWILB_KICK) && !need_resched())
> +		_nohz_idle_balance(cpu_rq(cpu), NOHZ_STATS_KICK, CPU_IDLE);
> +}

nit: need_resched() implies this_cpu, but the function signature implies you
could operate on any CPU. Do need_resched() outside this function or make
the function read smp_processor_id() itself without taking an arg?

Thanks

--
Qais Yousef