Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210304165300.295952-1-kieran.bingham+renesas@ideasonboard.com>
In-Reply-To: <20210304165300.295952-1-kieran.bingham+renesas@ideasonboard.com>
From:   Geert Uytterhoeven <geert@linux-m68k.org>
Date:   Fri, 5 Mar 2021 15:10:42 +0100
Message-ID: <CAMuHMdWRe0HVzQD9U_8+35_HTaK28Ayb+9tsb8q5+3VNpYniHg@mail.gmail.com>
Subject: Re: [PATCH] arm64: dts: renesas: falcon: Add GP LEDs
To:     Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
Cc:     Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi Kieran,

On Thu, Mar 4, 2021 at 5:53 PM Kieran Bingham
<kieran.bingham+renesas@ideasonboard.com> wrote:
> Three general purpose LEDs are provided on the Falcon CPU board.
>
> Connect GP_LED1, GP_LED2, and GP_LED3 to the gpio-leds frameworks.
> These LEDs are arranged in a block of four LEDs on the board itself, but
> the fourth LED is as yet unidentified.
>
> Signed-off-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>

Thanks for your patch!

> --- a/arch/arm64/boot/dts/renesas/r8a779a0-falcon.dts
> +++ b/arch/arm64/boot/dts/renesas/r8a779a0-falcon.dts

I believe the LEDs are on the CPU board, so they belong in
r8a779a0-falcon-cpu.dtsi instead?

> @@ -20,6 +20,20 @@ aliases {
>         chosen {
>                 stdout-path = "serial0:115200n8";
>         };
> +
> +       leds {
> +               compatible = "gpio-leds";
> +
> +               led1 {
> +                       gpios = <&gpio4 18 GPIO_ACTIVE_HIGH>;

Any need for other properties from
Documentation/devicetree/bindings/leds/common.yaml, like
color = <LED_COLOR_ID_GREEN>?

> +               };
> +               led2 {
> +                       gpios = <&gpio4 19 GPIO_ACTIVE_HIGH>;
> +               };
> +               led3 {
> +                       gpios = <&gpio4 20 GPIO_ACTIVE_HIGH>;
> +               };
> +       };
>  };

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds