Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp2048770pxb; Fri, 5 Mar 2021 06:18:21 -0800 (PST) X-Google-Smtp-Source: ABdhPJzky3IJquo2SpGBJjRy5F3X9/BwbJ+EAmAQuCfrVE6fn5AP1LEXGILGZzbB11xM6cAeU4cf X-Received: by 2002:a17:907:7799:: with SMTP id ky25mr2394925ejc.217.1614953901663; Fri, 05 Mar 2021 06:18:21 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1614953901; cv=none; d=google.com; s=arc-20160816; b=jnQ9076onCfvyPpB/Lkg3MFxEEZzEDpB6/EAaWTJp0tE6+WZh6dSd7SL8v81c00GtY 4BKnpS1sfLExdLUVVFVJe5Q8QJrzxQtW2fEFOX/mazFZLjmWAkVp0ohqpEyWCgyPnPdW jWunQE64ltxwtvbD3J+6aKBLM5WVu/Ri+GesGsUdPc8Saqxjph/i3B2pXGlS/2diDQ7j LoDeSlKoj3aPxjT0VCtG+nnB5XG9Sc5lvWCgvRtiG0WMWjx2nU/ZIB/1KRVOEH66FUcd 1Dk5fDN34N3wAwWXb0Lj+6KPDvht0hQTLdlHA857R4lbKyTwW+bxbyiWvXKRMIh+dK4o 8xZQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=oxJYTicBhp67Wglg540P1RE6uEWJ9j6ACzgSvrIEUbw=; b=FbTQiDlbdBMZzdUh6fwBgQ2vnwobFE4W5reyJCwHrrv0xijFea2u8rH0W8vFzJAmOn 1+VczohEropsH8MJrihhgPUKj/GYQTS7+DakFStJ22HYX5X7KQCDUUmGOSwBGUDvrqr9 BBkRFuouklpvH7x6psgjtAaGWUJ1BPqbZWlAnNCbwUlO7FCG9QWNjGE0yIhiU6JTM+6l XE4Ua/3vFyMmOxOnTIdSkLzQ99Nb8H4YPt/oJLaVdZuGM+xb/lysKx5QbiWEacbL6h4s ViYZTN8rNrIqEIJE3cuA+DnoYOPVko0AqFGEoCnMEDVhDsHKZfUgZgV1nvcmiEAIF+O+ uvpA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=ujT6mUNr; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id v28si1185817edl.428.2021.03.05.06.17.58; Fri, 05 Mar 2021 06:18:21 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=ujT6mUNr; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229701AbhCEOOl (ORCPT + 99 others); Fri, 5 Mar 2021 09:14:41 -0500 Received: from mail.kernel.org ([198.145.29.99]:58234 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230514AbhCEOOh (ORCPT ); Fri, 5 Mar 2021 09:14:37 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 6A0C06501A; Fri, 5 Mar 2021 14:14:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1614953676; bh=nJW/qzlXmQLjEx5WtjuS7q3GToRzq3WGjVZX19qD8Jg=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=ujT6mUNrqJ6jlXFWAX1PRjYK0tftZpfJWLEY3DbgBEJ/3/vZY2zPlcu+MPfP/f/C9 gxcjtYUNWqGHyIP9Offdvt5GU/9lHxv8AgwSewkvn98xQOyhslh/E3TD+W51q56Nkz 1GR68fvhBdnD7bdTOneaZ/DzbB8Su8/p/5IaM1MNgwvXqLnxwLTlUs8qTw3was3Ut+ b/k34hD8fPTzR7sA4hcj9I/mvl3YS09wjbpjo7NPx0tNYggrK048TXf4Vg7CBpfgRI RfPHFba9UWVx7rLCUvzU7IL0LBGymZCJZ8ZQ/J79ggYzOeK8B6xuw7wX6NOz2rFgiw jNOB5eYbz/9Cg== Received: by mail-ej1-f54.google.com with SMTP id c10so3700009ejx.9; Fri, 05 Mar 2021 06:14:36 -0800 (PST) X-Gm-Message-State: AOAM533JXMe/UOx97mPDBvOudoA4AmL2PsFIIbSr2XeiCQ25MrOFeMrp 1QwGe+ZQKF/lpLYpQbg9ajCo6yxvNRYRzDIgPw== X-Received: by 2002:a17:906:d153:: with SMTP id br19mr2329504ejb.360.1614953674952; Fri, 05 Mar 2021 06:14:34 -0800 (PST) MIME-Version: 1.0 References: <1614222604-27066-1-git-send-email-peng.fan@oss.nxp.com> <1614222604-27066-5-git-send-email-peng.fan@oss.nxp.com> In-Reply-To: From: Rob Herring Date: Fri, 5 Mar 2021 08:14:23 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH V3 4/5] dt-bindings: mmc: fsl-imx-esdhc: add clock bindings To: Aisheng Dong Cc: "Peng Fan (OSS)" , "sboyd@kernel.org" , "shawnguo@kernel.org" , "s.hauer@pengutronix.de" , "kernel@pengutronix.de" , "festevam@gmail.com" , dl-linux-imx , "ulf.hansson@linaro.org" , "adrian.hunter@intel.com" , "linux-clk@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "linux-mmc@vger.kernel.org" , Peng Fan Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Mar 5, 2021 at 8:09 AM Aisheng Dong wrote: > > Hi Rob, > > > From: Peng Fan (OSS) > > Sent: Thursday, February 25, 2021 11:10 AM > > > > From: Peng Fan > > > > Add clock bindings for fsl-imx-esdhc yaml > > > > Signed-off-by: Peng Fan > > --- > > .../devicetree/bindings/mmc/fsl-imx-esdhc.yaml | 11 +++++++++++ > > 1 file changed, 11 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml > > b/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml > > index a7fbd8cc1e38..369471814496 100644 > > --- a/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml > > +++ b/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml > > @@ -103,6 +103,17 @@ properties: > > Only eMMC HS400 mode need to take care of this property. > > default: 0 > > > > + clocks: > > + maxItems: 3 > > + description: > > + Handle clocks for the sdhc controller. > > + > > + clock-names: > > + items: > > + - const: ipg > > + - const: ahb > > + - const: per > > One question: > The side effect of this patch is that it imposes a forced order of clk names > In DT which actually was not needed. > > Do we really have to do that? Yes. > Or any other better approach to allow a random order to match the DT > usage better? Why do you need random order? We can not enforce the order, but we only do that when there's multiple optional entries. Rob