Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Reply-To: kieran.bingham+renesas@ideasonboard.com
Subject: Re: [PATCH] arm64: dts: renesas: falcon: Add GP LEDs
To:     Geert Uytterhoeven <geert@linux-m68k.org>
Cc:     Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
References: <20210304165300.295952-1-kieran.bingham+renesas@ideasonboard.com>
 <CAMuHMdWRe0HVzQD9U_8+35_HTaK28Ayb+9tsb8q5+3VNpYniHg@mail.gmail.com>
From:   Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
Organization: Ideas on Board
Message-ID: <17ee8b80-8522-7fb5-508d-6be18dea36d8@ideasonboard.com>
Date:   Fri, 5 Mar 2021 14:15:08 +0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <CAMuHMdWRe0HVzQD9U_8+35_HTaK28Ayb+9tsb8q5+3VNpYniHg@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-GB
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 05/03/2021 14:10, Geert Uytterhoeven wrote:
> Hi Kieran,
> 
> On Thu, Mar 4, 2021 at 5:53 PM Kieran Bingham
> <kieran.bingham+renesas@ideasonboard.com> wrote:
>> Three general purpose LEDs are provided on the Falcon CPU board.
>>
>> Connect GP_LED1, GP_LED2, and GP_LED3 to the gpio-leds frameworks.
>> These LEDs are arranged in a block of four LEDs on the board itself, but
>> the fourth LED is as yet unidentified.
>>
>> Signed-off-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
> 
> Thanks for your patch!
> 
>> --- a/arch/arm64/boot/dts/renesas/r8a779a0-falcon.dts
>> +++ b/arch/arm64/boot/dts/renesas/r8a779a0-falcon.dts
> 
> I believe the LEDs are on the CPU board, so they belong in
> r8a779a0-falcon-cpu.dtsi instead?

Yes, I hadn't quite grasped the layouts of this new board yet.

Sorry - I'll move it.


> 
>> @@ -20,6 +20,20 @@ aliases {
>>         chosen {
>>                 stdout-path = "serial0:115200n8";
>>         };
>> +
>> +       leds {
>> +               compatible = "gpio-leds";
>> +
>> +               led1 {
>> +                       gpios = <&gpio4 18 GPIO_ACTIVE_HIGH>;
> 
> Any need for other properties from
> Documentation/devicetree/bindings/leds/common.yaml, like
> color = <LED_COLOR_ID_GREEN>?

Oh, I wasn't aware of those. But indeed the LED is green, so it seems
appropriate.

I'll test it out, and see if I can make it glow red (jokes).


> 
>> +               };
>> +               led2 {
>> +                       gpios = <&gpio4 19 GPIO_ACTIVE_HIGH>;
>> +               };
>> +               led3 {
>> +                       gpios = <&gpio4 20 GPIO_ACTIVE_HIGH>;
>> +               };
>> +       };
>>  };
> 
> Gr{oetje,eeting}s,
> 
>                         Geert
>