Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 5 Mar 2021 09:21:36 -0500
From:   Steven Rostedt <rostedt@goodmis.org>
To:     <Viktor.Rosendahl@bmw.de>
Cc:     <vulab@iscas.ac.cn>, <linux-kernel@vger.kernel.org>,
        <colin.king@canonical.com>
Subject: Re: [PATCH] tracing/tools: Remove unneeded semicolon
Message-ID: <20210305092136.7f6a33d1@gandalf.local.home>
In-Reply-To: <480322830b8aa400f4293e635184a31d392e4dad.camel@bmw.de>
References: <20210305094005.1724-1-vulab@iscas.ac.cn>
        <480322830b8aa400f4293e635184a31d392e4dad.camel@bmw.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Fri, 5 Mar 2021 10:42:08 +0000
<Viktor.Rosendahl@bmw.de> wrote:

> Looks good but I would suggest to fix also the other instances of superfluous
> semicolons with the same patch.
> 
> There seems to be a lonely semicolon on line 1944, i.e this code:
> 
> 			if (value < 0) {
> 				warnx("TIME must be >= 0\n");
> 				show_usage();
> 				;
> 			}
> 
> In that case the lonely semicolon should be replaced with "exit(0);"

Agreed. I'll wait for v2 of the patch.

Thanks,

-- Steve