Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH V2] docs: livepatch: Fix a typo and remove the unnecessary
 gaps in a sentence
To:     Bhaskar Chowdhury <unixbhaskar@gmail.com>,
        Matthew Wilcox <willy@infradead.org>, jpoimboe@redhat.com,
        jikos@kernel.org, mbenes@suse.cz, pmladek@suse.com, corbet@lwn.net,
        live-patching@vger.kernel.org, linux-doc@vger.kernel.org,
        linux-kernel@vger.kernel.org, rdunlap@infradead.org
References: <20210305100923.3731-1-unixbhaskar@gmail.com>
 <20210305125600.GM2723601@casper.infradead.org> <YEI0EcR5G53IoYzb@Gentoo>
From:   Joe Lawrence <joe.lawrence@redhat.com>
Message-ID: <f8b10ee7-026c-1dc0-fb0c-2a887cd1e953@redhat.com>
Date:   Fri, 5 Mar 2021 11:00:10 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.7.0
MIME-Version: 1.0
In-Reply-To: <YEI0EcR5G53IoYzb@Gentoo>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 3/5/21 8:37 AM, Bhaskar Chowdhury wrote:
> On 12:56 Fri 05 Mar 2021, Matthew Wilcox wrote:
>> On Fri, Mar 05, 2021 at 03:39:23PM +0530, Bhaskar Chowdhury wrote:
>>> s/varibles/variables/
>>>
>>> ...and remove leading spaces from a sentence.
>>
>> What do you mean 'leading spaces'?  Separating two sentences with
>> one space or two is a matter of personal style, and we do not attempt
>> to enforce a particular style in the kernel.
>>
> The spaces before the "In" .. nor I am imposing anything , it was peter caught
> and told me that it is hanging ..move it to the next line ..so I did. ..
> 

Initially I thought the same as Matthew, but after inspecting the diff I 
realized it was just a line wrap.  Looks fine to me.

>>>   Sometimes it may not be convenient or possible to allocate shadow
>>>   variables alongside their parent objects.  Or a livepatch fix may
>>> -require shadow varibles to only a subset of parent object instances.  In
>>> +require shadow variables to only a subset of parent object instances.
>>
>> wrong preposition, s/to/for/    ..where???

Hi Bhaskar,

Thanks for spotting, I'd be happy with v2 as is or a v3 if you want to 
update s/shadow variables to only/shadow variables for only/  but 
knowing me, I probably repeated the same phrasing elsewhere.  Up to you, 
thanks.

Acked-by: Joe Lawrence <joe.lawrence@redhat.com>

-- Joe