Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp2168556pxb; Fri, 5 Mar 2021 08:45:54 -0800 (PST) X-Google-Smtp-Source: ABdhPJw1Azm6mixKm9M0CZK1WXr5qm0XVeHj2T46no3WO6+Ug1tRMnjPdbDquyLvaY9MghC3WQTz X-Received: by 2002:aa7:d656:: with SMTP id v22mr9653585edr.119.1614962754522; Fri, 05 Mar 2021 08:45:54 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1614962754; cv=none; d=google.com; s=arc-20160816; b=nXnscDGAxi+Xt5v6Hb5D8u5TQ8Tdq3xYo88mKN3OdMnhAzdjuL98YajmtNdpmHW2ZZ nS5I5nX/ufQbNN+JAyzK9cWejkOtpEAvGwcV3zpqYlO56KiRr9+ABjs44nqzOZA26YMs 9JSUnXaV2sJs9ARClk41+nLt8E6oUwADUU286TCPXBUAb5cDEH1a1WXCD1jKgPi9dHad T2cUXHuK32tn6WWZmuFnaYTy6pD1PVmy+2zSckQvxpOHJFJ84ySKdSEn34qhBJCRr4AA GaIjA4gCHGh+ZCmAx9fQCGYQ5t0sXWiumAUXhdXSDRU5/zkNOzo4tTE1+IWpBk32Ntxy dD3A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=Idz6IhNVmVDwrmS9eS02rzcFdMoaAKDHYFFgO5wjPbU=; b=ucAq5ijqRz3f4AXtZrg4tpqUnW+tu6CXEDTPHnkn0D7YnjvBvedDTMnuRvxlS5lUdN hp/e9HlwN7KUMldTv8EuNFdD1IA3rZDQwOeqIg9yy5R94nrA4dcil6L0P0bIEH3+NcNe S/S4BYc6ur3BB+09W5w0S5I6f2TFjhjJUn0Vhe9ZDlJhE/9f85T9uuPxf5K3pgFrhIYQ YtuN5W6yGfL29U6B6PqXjU3msR1J8Rwmro7aUs/4PFQFHTz3SRaATE4w4z5yimtAI4al oK9R2maKaawAj0XS8D1kYkKr9Zo4mBTUXuR615Ti+VPv4qnoGSu5msMS+nXzuxIq12/Q fKCg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=O2TrIrVF; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id s17si1929169edx.88.2021.03.05.08.45.31; Fri, 05 Mar 2021 08:45:54 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=O2TrIrVF; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231286AbhCEQm0 (ORCPT + 99 others); Fri, 5 Mar 2021 11:42:26 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34646 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230179AbhCEQmO (ORCPT ); Fri, 5 Mar 2021 11:42:14 -0500 Received: from mail-lj1-x22c.google.com (mail-lj1-x22c.google.com [IPv6:2a00:1450:4864:20::22c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F336CC061574 for ; Fri, 5 Mar 2021 08:42:13 -0800 (PST) Received: by mail-lj1-x22c.google.com with SMTP id u18so3589525ljd.3 for ; Fri, 05 Mar 2021 08:42:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Idz6IhNVmVDwrmS9eS02rzcFdMoaAKDHYFFgO5wjPbU=; b=O2TrIrVFHinCDdMspBfmxsGMiJUlgXCqYQ5/0BckQ2Iqy1homQEhVrIQ0XJsIYpaiW +YcSkkOPteNMhOlE5U2GaaBp/HMTEYNawtAoNNIkRe/tsVEzJ4PZB1KAAThN973pDjue IjS6Zw/SOn6Xkj9MzXByMZP+d6xnuMFtlm3qOV4cT/bLE9T0j7pRISgBlXx8E+WEG+s0 Ikc8YL/wTRFWi8DIjOcRUcsXe4QWct1oDvtVTIFV9IFP20cP91zKojuI6/SOhAOV27bO G/2Lnq7h5vsbliyITp9Bs3FcRyDoP2/5N+/HduaduYJDav5igamHgTT/8kSXaey2iA37 KhHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Idz6IhNVmVDwrmS9eS02rzcFdMoaAKDHYFFgO5wjPbU=; b=uWODky6HGFk3z7OVK9eCWJrQ0gOI9IxEZPpmooyK9GolExLYY50ZN5qF+ZjDL93G6N +ryoNjef1YrO/rjPLpWD6BIVww76mBoajvrbu2f6osEQWg6uvjLMWXvs8QR00+H5UtI6 XCjX4qHtvIzIb6Ej1Q7gy7lkmeGQiK/leUNVgHpiVwnMg/NJRPRAxrky9zExciS2sJUL Wdzz7aHnoGa9uivbWZyQLuOjvWQkpChg9+pgti5PFKZQoNlBiDBLY6aQ4Nns34FYDXmm mQNuCZsGUBlu8lsOP1uvipTkzg5WnLzBTJ+cIt0wN7IgZMeThMYFCtr8YRdY58I4rp0r Qzuw== X-Gm-Message-State: AOAM532YIg98cQmPdwVeCZBYV11ls+8F/LsUV3Nokw89BZ97Z1y3m7T8 xA6UtYawqEUtefasckWrPnWE68mhoRXLOWJc+6TTFA== X-Received: by 2002:a2e:2f05:: with SMTP id v5mr5701469ljv.279.1614962532286; Fri, 05 Mar 2021 08:42:12 -0800 (PST) MIME-Version: 1.0 References: <20210304014229.521351-1-shakeelb@google.com> In-Reply-To: From: Shakeel Butt Date: Fri, 5 Mar 2021 08:42:00 -0800 Message-ID: Subject: Re: [PATCH v3] memcg: charge before adding to swapcache on swapin To: Johannes Weiner Cc: Hugh Dickins , Roman Gushchin , Michal Hocko , Andrew Morton , Cgroups , Linux MM , LKML Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Mar 5, 2021 at 8:25 AM Johannes Weiner wrote: > [...] > I'd also rename cgroup_memory_noswap to cgroup_swapaccount - to match > the commandline and (hopefully) make a bit clearer what it effects. Do we really need to keep supporting "swapaccount=0"? Is swap page_counter really a performance issue for systems with memcg and swap? To me, deprecating "swapaccount=0" simplifies already complicated code.