Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 5 Mar 2021 14:41:52 -0600
From:   Rob Herring <robh@kernel.org>
To:     Krzysztof Kozlowski <krzk@kernel.org>
Cc:     Marek Szyprowski <m.szyprowski@samsung.com>,
        Jonathan Cameron <jic23@kernel.org>,
        Lars-Peter Clausen <lars@metafoo.de>,
        Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
        Lee Jones <lee.jones@linaro.org>,
        Mark Brown <broonie@kernel.org>, linux-iio@vger.kernel.org,
        devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: iio: samsung,exynos-adc: add common clock
 properties
Message-ID: <20210305204152.GA607635@robh.at.kernel.org>
References: <CGME20210212164148eucas1p2ab09436a82d50161ff1a9fc1a169f7d7@eucas1p2.samsung.com>
 <20210212163816.70058-1-krzk@kernel.org>
 <85ed4a70-5cd8-3bce-100f-33a1fba7f3fa@samsung.com>
 <20210215092915.7khog24shtzjzd6g@kozik-lap>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210215092915.7khog24shtzjzd6g@kozik-lap>
Precedence: bulk

On Mon, Feb 15, 2021 at 10:29:15AM +0100, Krzysztof Kozlowski wrote:
> On Mon, Feb 15, 2021 at 10:01:48AM +0100, Marek Szyprowski wrote:
> > Hi Krzysztof,
> > 
> > On 12.02.2021 17:38, Krzysztof Kozlowski wrote:
> > > Add common properties appearing in DTSes (assigned-clocks and similar)
> > > to fix dtbs_check warnings like:
> > >
> > >    arch/arm/boot/dts/exynos3250-artik5-eval.dt.yaml:
> > >      adc@126c0000: assigned-clock-rates: [[6000000]] is not of type 'object'
> > >    arch/arm/boot/dts/exynos3250-artik5-eval.dt.yaml:
> > >      adc@126c0000: assigned-clocks: [[7, 238]] is not of type 'object'
> > 
> > Does it mean that assigned-clocks related properties have to be added to 
> > almost all bindings?
> 
> To my understanding: yes, and we already added it to multiple schemas.
> 
> > IMHO this is an over-engineering and this has to be 
> > handled somewhere else...
> 
> Would have to be made a part of the core schema (just like pinctrl nodes
> etc).

That's the case now. It's contingent on having a 'clocks' property in 
the node.

Rob