Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 5 Mar 2021 15:22:21 -0600
From:   Rob Herring <robh@kernel.org>
To:     Orson Zhai <orsonzhai@gmail.com>
Cc:     Baolin Wang <baolin.wang7@gmail.com>,
        Chunyan Zhang <zhang.lyra@gmail.com>,
        Jassi Brar <jassisinghbrar@gmail.com>,
        Mark Brown <broonie@kernel.org>, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org,
        Haidong Yao <yaohaidong369@gmail.com>,
        Orson Zhai <orson.zhai@unisoc.com>
Subject: Re: [PATCH v2 2/3] dt-bindings: mailbox: Add interrupt-names to SPRD
 mailbox
Message-ID: <20210305212221.GA667054@robh.at.kernel.org>
References: <20210213122143.19240-1-orsonzhai@gmail.com>
 <20210213122143.19240-3-orsonzhai@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210213122143.19240-3-orsonzhai@gmail.com>
Precedence: bulk

On Sat, Feb 13, 2021 at 08:21:42PM +0800, Orson Zhai wrote:
> From: Orson Zhai <orson.zhai@unisoc.com>
> 
> We add an optional supp-outbox interrupt support to SPRD mailbox driver
> with newly added sc9863a support and change to configure interrupts with
> names in device tree files.
> 
> Signed-off-by: Orson Zhai <orson.zhai@unisoc.com>
> ---
>  .../bindings/mailbox/sprd-mailbox.yaml         | 18 +++++++++++++++---
>  1 file changed, 15 insertions(+), 3 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/mailbox/sprd-mailbox.yaml b/Documentation/devicetree/bindings/mailbox/sprd-mailbox.yaml
> index 26a5cca3f838..67736450ee93 100644
> --- a/Documentation/devicetree/bindings/mailbox/sprd-mailbox.yaml
> +++ b/Documentation/devicetree/bindings/mailbox/sprd-mailbox.yaml
> @@ -15,6 +15,7 @@ properties:
>    compatible:
>      enum:
>        - sprd,sc9860-mailbox
> +      - sprd,sc9863a-mailbox
>  
>    reg:
>      items:
> @@ -22,9 +23,18 @@ properties:
>        - description: outbox registers' base address
>  
>    interrupts:
> -    items:
> -      - description: inbox interrupt
> -      - description: outbox interrupt
> +    minItems: 2
> +    maxItems: 3
> +
> +  interrupt-names:
> +    oneOf:
> +      - items:
> +          - const: inbox
> +          - const: outbox
> +      - items:
> +          - const: inbox
> +          - const: outbox
> +          - const: supp-outbox

You can do this instead:

interrupt-names:
  minItems: 2
  items:
    - const: inbox
    - const: outbox
    - const: supp-outbox

>  
>    clocks:
>      maxItems: 1
> @@ -40,6 +50,7 @@ required:
>    - compatible
>    - reg
>    - interrupts
> +  - interrupt-names
>    - "#mbox-cells"
>    - clocks
>    - clock-names
> @@ -56,5 +67,6 @@ examples:
>        clock-names = "enable";
>        clocks = <&aon_gate 53>;
>        interrupts = <GIC_SPI 28 IRQ_TYPE_LEVEL_HIGH>, <GIC_SPI 29 IRQ_TYPE_LEVEL_HIGH>;
> +      interrupt-names = "inbox", "outbox";
>      };
>  ...
> -- 
> 2.17.1
>