Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp485257pxb; Sat, 6 Mar 2021 06:17:38 -0800 (PST) X-Google-Smtp-Source: ABdhPJya4w777QQpVwNSPPxLb/WJDfLkllj9TEIPljoWWDB744Sn2sP4bhWMFwAbPD23tAKGvKhr X-Received: by 2002:a17:906:5811:: with SMTP id m17mr7218509ejq.115.1615040258322; Sat, 06 Mar 2021 06:17:38 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1615040258; cv=none; d=google.com; s=arc-20160816; b=M9U/ujslUCkJ0acSXumW0gIyJ7/1vEp9Aw5OkED0GKdACTGGFQ/4E5ufLfOndaq3Wv /LwDiA2kDVPLVED2FR4ORiNBgezzLNHv5Bf9Yben38eK1z5yXNi3cCVCOaPZwulo18gH hgxLhn4olEJBiLUJAyVIPZk3fTeSuPBzFkNmhfWR4DQafqSgdwxDakRe5KdMX9mqQ/h0 eUOgLU1pnpCyBTCwpWhxuKkFepFgD41AlsvHqRCI1qiWTCCaCSNE755QEl6+ohgf7Mmt EZ8UF3HPhjGuq2AUaZ/V4QOWGk2ZX77G/d4GOVncYSW6SOHIbsB49UdnvrMrR57FawxC Twpw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:subject:cc:to:from :dkim-signature; bh=X8TTCBPkViEllxII2GAPq686qNKT8VhCeBCNCuQb630=; b=adwajT/3nMsg2ez0khBCIZrVYo/rz1jPUFR4EmcDeiytv3A2YiTPGUDsLRACilG6mU T/ibeV4NEnKqxO8S5ZvUKn3+k44bmEt1YWvBNWVCOROEGYom5gEj1n9e5gFrpv6MQRTt 2od9MtmDnl4LuafOwDHVV8p6kFo4TwrLB/d4BPYR7X20Gvrz1ujpd6WurQ4p+MLYSK7J 8yM5TrCanqYICXVPLkcGc9Lq5Bo+W5PKgLUMhS2NNJihA/CMHNtmqF6sixECxx9VeCsK gHB2CHv8G/xApMq9S08X+LYaahkc1UsRCRRejfVzKwStdiu5G+gEL/uQiyacqBIaBMXm IkVQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=X4HjQFXJ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id g2si3404690ejs.58.2021.03.06.06.17.13; Sat, 06 Mar 2021 06:17:38 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=X4HjQFXJ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230449AbhCFOQG (ORCPT + 99 others); Sat, 6 Mar 2021 09:16:06 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57322 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230213AbhCFOPp (ORCPT ); Sat, 6 Mar 2021 09:15:45 -0500 Received: from mail-pl1-x636.google.com (mail-pl1-x636.google.com [IPv6:2607:f8b0:4864:20::636]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C2629C06174A; Sat, 6 Mar 2021 06:15:44 -0800 (PST) Received: by mail-pl1-x636.google.com with SMTP id j6so2824033plx.6; Sat, 06 Mar 2021 06:15:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=X8TTCBPkViEllxII2GAPq686qNKT8VhCeBCNCuQb630=; b=X4HjQFXJ5I+4Ga5ghW9W0m+NFQmbaZvOV/98ZlS9tGmLGyTFguBYAqaluWx6xhXs5x +Flxm6eUBr75IEMaL91AqyIrG0WtRsQKeK9WEFTtsywnpiLhd9CCkOQxxetDnNTJr+eH 3z1yvhdANnQdGU+jcpbmOL7qTJOKvuGjQrAp72HicTG7vJVHyI7VIF4w8oQn5Z3UA0wr 2grs5Nhohf7kdBvXkNe7YyFG1hdlnQjW/h9WmqNNxIrLvE44Wdmto/OgVQWeqwNe1fOg hZVJR6PWKGyPL2vth00xb01ROaTnNFPNx1ykVUcZlHJ0DGcq7Uzs3PE7HCqHehn/Sr9U uGAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=X8TTCBPkViEllxII2GAPq686qNKT8VhCeBCNCuQb630=; b=pcSnV0nnErMm6j0FizIuNYqrn2TgC17qaCTayuq3W3vja10Ul/b/nXDx6gvPGOSnv5 3I9+SPdP7e3IzPz6RMZkl6P0hhQCfCBK6wpazZo/3+wtN0ssZkuqnLM0wDkuaqc0L5WD gabPRZY3sMbJt81w7rBSENXC5+XiiN5KcoKE8HgeoCDH57j/YOUHGjjTgi9GuotYww0/ 4dz6bjB84tYuIq3vtli5TiHPyrscYQtB5DP4QuOPKlfOG8JZwde0E3Q6y8aj4spWMMSE QvrZL4O/zeaLXA0IV+7A2nzwMURp+T2w6bRNV0M5BjtfSe/dtIyrjcpZiBzC0LJLuAPH O1yw== X-Gm-Message-State: AOAM531oSUyVSyY6zisNxKvFxg+f1uymwA6ulqiyKg4m9klgg3FPrsQE EPXjvzCscavkAZfUl9n9/DE= X-Received: by 2002:a17:90a:e50c:: with SMTP id t12mr15289117pjy.138.1615040144308; Sat, 06 Mar 2021 06:15:44 -0800 (PST) Received: from localhost.localdomain ([45.135.186.79]) by smtp.gmail.com with ESMTPSA id 64sm5516888pfd.174.2021.03.06.06.15.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 06 Mar 2021 06:15:43 -0800 (PST) From: Jia-Ju Bai To: yong.deng@magewell.com, mchehab@kernel.org, mripard@kernel.org, wens@csie.org, jernej.skrabec@siol.net Cc: linux-media@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Jia-Ju Bai Subject: [PATCH] media: platform: sunxi: sun6i-csi: fix error return code of sun6i_video_start_streaming() Date: Sat, 6 Mar 2021 06:15:28 -0800 Message-Id: <20210306141528.18925-1-baijiaju1990@gmail.com> X-Mailer: git-send-email 2.17.1 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org When sun6i_video_remote_subdev() returns NULL to subdev, no error return code of sun6i_video_start_streaming() is assigned. To fix this bug, ret is assigned with -EINVAL in this case. Reported-by: TOTE Robot Signed-off-by: Jia-Ju Bai --- drivers/media/platform/sunxi/sun6i-csi/sun6i_video.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/media/platform/sunxi/sun6i-csi/sun6i_video.c b/drivers/media/platform/sunxi/sun6i-csi/sun6i_video.c index b55de9ab64d8..3181d0781b61 100644 --- a/drivers/media/platform/sunxi/sun6i-csi/sun6i_video.c +++ b/drivers/media/platform/sunxi/sun6i-csi/sun6i_video.c @@ -151,8 +151,10 @@ static int sun6i_video_start_streaming(struct vb2_queue *vq, unsigned int count) } subdev = sun6i_video_remote_subdev(video, NULL); - if (!subdev) + if (!subdev) { + ret = -EINVAL; goto stop_media_pipeline; + } config.pixelformat = video->fmt.fmt.pix.pixelformat; config.code = video->mbus_code; -- 2.17.1