Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp540497pxb; Sat, 6 Mar 2021 08:02:29 -0800 (PST) X-Google-Smtp-Source: ABdhPJxC2zWJRfP0nuObcpnOM6I4hpG/7C3XBrkNgcavLPx44NfDB/sttIA1JKGbcmVyBqjVN+Qh X-Received: by 2002:a17:907:9808:: with SMTP id ji8mr5657855ejc.333.1615046549272; Sat, 06 Mar 2021 08:02:29 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1615046549; cv=none; d=google.com; s=arc-20160816; b=fFylhr0Zq1By5uNG5lHvyW8f7Et11Nmw8NyyN/BsNevnUPnvxCElTEPtjTv9cXZBQB nhMJPQ9MmZ1Tyizqn63rJAS9E+6NlW5TjuGhLThhqOCAQrmiAH4dGZoAQelXe82cfMiD ffd8kOhta0Qj9zHOdvsk5VsgEQc7VYGruo4KeZsHth8uDlLLWUYrSu8xXO6wB66QLU1D JAss09Jnl1cXX79uR4RFxAXyLTzmotzCFCJ1I05uJnZLdHlJBa9KjBre2F9UkTQzYRT6 71uugXoRtmTG5Z1hN/jADjskNDu/wmIk/6joyaozhYQ63I/lFs2X3cIINg31T04R26fm irAw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=PcCnT8hlePYBrVx9+vaY6Viur8QCCOHDFsB+RfHcbdI=; b=ijj7ORzzUsxwYe4+GK2f5LznQhfnDyEimJSP+xd+lOpyZaqM7ZOlvrDaBOIIKrA66T vhBVzdD+THpTS/bMsdKXqg7YLjv4X3KX79wE3v8JpZ2lh+slYzWKpC1BKpNQ7qL+Ix7Y 95TeItV/LoGZ7Tl0ECk+mN93PSZ5dYH0OTYz6M29025T6O1KVZ4lm54t3cXxcpsmeinE MCaURvbUGIZGby5J0wkmEyKDsCUjjaf0nCYHKEHbHRxnGN99n1QpCGaTOAwTHko4hGhp JD/QQXDAvmB5Uz/3I4W0Sg3aXtcFZ0LOg4fAWjT9p1OFT6wkdwPuf6oFd5jKHAiSYYuE FBvA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=MTuXyPDl; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id hq38si3331766ejc.350.2021.03.06.08.02.06; Sat, 06 Mar 2021 08:02:29 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=MTuXyPDl; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231190AbhCFP5s (ORCPT + 99 others); Sat, 6 Mar 2021 10:57:48 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50910 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230429AbhCFP5Q (ORCPT ); Sat, 6 Mar 2021 10:57:16 -0500 Received: from mail-wm1-x32f.google.com (mail-wm1-x32f.google.com [IPv6:2a00:1450:4864:20::32f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2B2CBC06174A; Sat, 6 Mar 2021 07:57:16 -0800 (PST) Received: by mail-wm1-x32f.google.com with SMTP id r10-20020a05600c35cab029010c946c95easo1124548wmq.4; Sat, 06 Mar 2021 07:57:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:in-reply-to:references:mime-version :content-transfer-encoding; bh=PcCnT8hlePYBrVx9+vaY6Viur8QCCOHDFsB+RfHcbdI=; b=MTuXyPDlVhV+cpBWlaU/KIhgzHKNYscLm3fbJhN+iR6TRNY3HCVRm0ObtckAdqD8oD mHak32ZxcjBcMpIWnsvMegmUO1R9gf3Ay/qE8trTUlmtoAuuCnsBCNABwL5dwWrJ+MEb lOYmDhf/aTPPZ/TeAAQ8v6sC46ZRXAJ6MintQeNm13XttiIdZAoDQlgLYMxsCeeG989S n/8Qes3xrSiBgtqw0MME2/5sv5dq/MUk//qNpUF88jnHp4l2lPu9C5ZvJi5B4CEtUj47 18RbFHJzwJkle4d1UutAM8Mw55518cGhpPZXfzKEC2h9vnNXTzSZ7eAFoxVq0umwbBO0 6qTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=PcCnT8hlePYBrVx9+vaY6Viur8QCCOHDFsB+RfHcbdI=; b=Mg3WHfrpB2EJjaIuQzVm2opaTsy6cs38str/Xp8lNG4kkKwHzBF2wlTcwuuuZDjnTK Nv+F6HHk5HXPsBIr5ioa1iZKFMoQ0ddPKRGn5gR0SymdDzvHQw1Mt69UGizKR4QE1uOt qnm5TEFmhH9xB+2uyH91SwzrJ8zYP+AGbQMCc8b9OdqnAJmc1d7PAV6Q+K6BqYM6tKhm DUq3pQKTWRTmJVjPUzmpqoCqD3/5XZ89JNNw2yd56GzcF92mBvp+AF5XO+OxPAjDdaG3 hk4ejxpiNji6aozi2DJz2/CgD5cSNDM/Qn7OhLReWr0MtYMXRgDSL3yIsxuJW15j0UiB kkBg== X-Gm-Message-State: AOAM531XYsACIwqyWlF9dda0KClX0Lu7S3IC1sSHn2Ex00k+pdiGWc8k QwOHqV2Xes9SnRID2wTGUTwOIJGpibtgkA== X-Received: by 2002:a1c:bb0b:: with SMTP id l11mr14468249wmf.150.1615046234857; Sat, 06 Mar 2021 07:57:14 -0800 (PST) Received: from skynet.lan (224.red-2-138-103.dynamicip.rima-tde.net. [2.138.103.224]) by smtp.gmail.com with ESMTPSA id p6sm9315188wru.2.2021.03.06.07.57.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 06 Mar 2021 07:57:14 -0800 (PST) From: =?UTF-8?q?=C3=81lvaro=20Fern=C3=A1ndez=20Rojas?= To: Linus Walleij , Rob Herring , Michael Walle , Bartosz Golaszewski , Florian Fainelli , bcm-kernel-feedback-list@broadcom.com, Jonas Gorski , =?UTF-8?q?=C3=81lvaro=20Fern=C3=A1ndez=20Rojas?= , Necip Fazil Yildiran , Andy Shevchenko , linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH v5 01/15] gpio: guard gpiochip_irqchip_add_domain() with GPIOLIB_IRQCHIP Date: Sat, 6 Mar 2021 16:56:58 +0100 Message-Id: <20210306155712.4298-2-noltari@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20210306155712.4298-1-noltari@gmail.com> References: <20210306155712.4298-1-noltari@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The current code doesn't check if GPIOLIB_IRQCHIP is enabled, which results in a compilation error when trying to build gpio-regmap if CONFIG_GPIOLIB_IRQCHIP isn't enabled. Fixes: 6a45b0e2589f ("gpiolib: Introduce gpiochip_irqchip_add_domain()") Suggested-by: Michael Walle Signed-off-by: Álvaro Fernández Rojas --- v5: add missing Suggested-by tag v4: add patch (fix include instead of gpio-regmap.c) include/linux/gpio/driver.h | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/include/linux/gpio/driver.h b/include/linux/gpio/driver.h index 286de0520574..ecf0032a0995 100644 --- a/include/linux/gpio/driver.h +++ b/include/linux/gpio/driver.h @@ -624,8 +624,17 @@ void gpiochip_irq_domain_deactivate(struct irq_domain *domain, bool gpiochip_irqchip_irq_valid(const struct gpio_chip *gc, unsigned int offset); +#ifdef CONFIG_GPIOLIB_IRQCHIP int gpiochip_irqchip_add_domain(struct gpio_chip *gc, struct irq_domain *domain); +#else +static inline int gpiochip_irqchip_add_domain(struct gpio_chip *gc, + struct irq_domain *domain) +{ + WARN_ON(1); + return -EINVAL; +} +#endif int gpiochip_generic_request(struct gpio_chip *gc, unsigned int offset); void gpiochip_generic_free(struct gpio_chip *gc, unsigned int offset); -- 2.20.1