Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp581378pxb; Sat, 6 Mar 2021 09:18:42 -0800 (PST) X-Google-Smtp-Source: ABdhPJwxuO+OAKH29PNamOUHH3OFo/oP///83CJp3vQKdbBhXHeOxnDX2CwjZAqulDHi3wINnWfm X-Received: by 2002:a17:906:add7:: with SMTP id lb23mr7615772ejb.273.1615051121955; Sat, 06 Mar 2021 09:18:41 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1615051121; cv=none; d=google.com; s=arc-20160816; b=Ch5+lIb7XqMfkNXeYw+iSv/ZaxNt149p/fLEmHMp4sTwCTQUnXiaPPW5Ouf5M8z+KP ysaO6LWo2ANdw3s60dAJ+vvwg4LScsqm6z2ilAQfV1VBNw+PSAvs2eV9Ej42q5CnuvHf SEcA0bM2UNuVsn28cQdP42qnCJutC0ZcnWRwntw0H3DhAhZdrGv3hJablX8Ji2gPSi4I THHTULcS76m67/u6YKiMc4i1tho59OXM/vhkQDWwlXtQZ3frQLmpxYSc7v6amUVm1uXo C8rxc9MBXL2gezjQLlQMdVU7yXWbrGe/Bg8WoFoEC5R2w8PulZlTuLZeUEVMw/5wzT0m XDOQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date; bh=OacV6P4tKjfFdcmVJqvXwcBfHXymDfhUiJ74L4y5qqo=; b=d6ENczWkADd+Mbksl+El9FGm0XKBVuyab0p7RecRldEYdg5lMKbpFrx/xA/iXaTex5 YV66hp9h18dJxpbQ/f1nq9nct+3nQSg4VK9tXR+gfKFCmDPlHDaTwj+41WdYFA5oG50w zsa4Cg4Kpv+eA9afC0Pl9XPAOFQg7LF4mWFrDEwuBbSYW9rR4lmjIJWxfvfH6mNaQccN JdTX8xae1dcLir3i029C2FFwtK2k9z9IbWTg/Uez3J146cxQCo5IhbjIwu/1lW5Pt8gE HdP+Erm9pAJ/Ao89hIH85Ck9hQnIggIo2Z08O9C5OFplvSlbJHvl/HHtwUH35qj+VLrC s8dw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id m13si3797367edd.35.2021.03.06.09.18.19; Sat, 06 Mar 2021 09:18:41 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230449AbhCFRRG (ORCPT + 99 others); Sat, 6 Mar 2021 12:17:06 -0500 Received: from mail.kernel.org ([198.145.29.99]:58050 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229779AbhCFRQ3 (ORCPT ); Sat, 6 Mar 2021 12:16:29 -0500 Received: from archlinux (cpc108967-cmbg20-2-0-cust86.5-4.cable.virginm.net [81.101.6.87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 08C8C64FE8; Sat, 6 Mar 2021 17:16:26 +0000 (UTC) Date: Sat, 6 Mar 2021 17:16:23 +0000 From: Jonathan Cameron To: Linus Walleij Cc: Dinghao Liu , Kangjie Lu , Lars-Peter Clausen , Peter Meerwald-Stadler , linux-iio , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] iio: gyro: mpu3050: Fix error handling in mpu3050_trigger_handler Message-ID: <20210306171623.41a9e664@archlinux> In-Reply-To: References: <20210301080421.13436-1-dinghao.liu@zju.edu.cn> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2 Mar 2021 16:45:10 +0100 Linus Walleij wrote: > On Mon, Mar 1, 2021 at 9:04 AM Dinghao Liu wrote: > > > There is one regmap_bulk_read() call in mpu3050_trigger_handler > > that we have caught its return value bug lack further handling. > > Check and terminate the execution flow just like the other three > > regmap_bulk_read() calls in this function. > > > > Signed-off-by: Dinghao Liu > > OK that makes sense. > Reviewed-by: Linus Walleij Applied with a fixes tag (it goes all the way back) and marked for stable. Thanks, Jonathan > > Yours, > Linus Walleij