Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Sat, 6 Mar 2021 13:14:04 -0700
From:   Rob Herring <robh@kernel.org>
To:     =?iso-8859-1?Q?=C1lvaro_Fern=E1ndez?= Rojas <noltari@gmail.com>
Cc:     Thomas Gleixner <tglx@linutronix.de>,
        Marc Zyngier <maz@kernel.org>,
        Florian Fainelli <f.fainelli@gmail.com>,
        Jonas Gorski <jonas.gorski@gmail.com>,
        linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
        bcm-kernel-feedback-list@broadcom.com, linux-mips@vger.kernel.org
Subject: Re: [PATCH v2 1/2] dt-bindings: interrupt-controller: document
 BCM6345 external interrupt controller
Message-ID: <20210306201404.GB1137882@robh.at.kernel.org>
References: <20210223204340.312-1-noltari@gmail.com>
 <20210224075640.20465-1-noltari@gmail.com>
 <20210224075640.20465-2-noltari@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20210224075640.20465-2-noltari@gmail.com>
Precedence: bulk

On Wed, Feb 24, 2021 at 08:56:39AM +0100, ?lvaro Fern?ndez Rojas wrote:
> Document the binding for the BCM6345 external interrupt controller.
> 
> Signed-off-by: ?lvaro Fern?ndez Rojas <noltari@gmail.com>
> Signed-off-by: Jonas Gorski <jonas.gorski@gmail.com>
> Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
> ---
>  v3: pass dt_binding_check.
>  v2: fix title typo.
> 
>  .../brcm,bcm6345-ext-intc.yaml                | 78 +++++++++++++++++++
>  1 file changed, 78 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/interrupt-controller/brcm,bcm6345-ext-intc.yaml
> 
> diff --git a/Documentation/devicetree/bindings/interrupt-controller/brcm,bcm6345-ext-intc.yaml b/Documentation/devicetree/bindings/interrupt-controller/brcm,bcm6345-ext-intc.yaml
> new file mode 100644
> index 000000000000..a691510e78b7
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/interrupt-controller/brcm,bcm6345-ext-intc.yaml
> @@ -0,0 +1,78 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/interrupt-controller/brcm,bcm6345-ext-intc.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Broadcom BCM6345 external interrupt controller
> +
> +maintainers:
> +  - ?lvaro Fern?ndez Rojas <noltari@gmail.com>
> +  - Jonas Gorski <jonas.gorski@gmail.com>
> +
> +properties:
> +  compatible:
> +    enum:
> +      - brcm,bcm6318-ext-intc
> +      - brcm,bcm6345-ext-intc
> +
> +  "#interrupt-cells":
> +    const: 2
> +
> +  reg:
> +    maxItems: 1
> +
> +  "#address-cells":
> +    const: 0
> +
> +  interrupt-controller: true
> +
> +  interrupts:
> +    description: Specifies the interrupt line(s) in the interrupt-parent
> +      controller node. Valid values depend on the type of parent interrupt
> +      controller.
> +    maxItems: 4
> +
> +  brcm,field-width:
> +    description: Interrupt controller field width (the default is 4).

default: 4

> +    maxItems: 1

All uint32's are 1 item.

What's the set or range of values?

> +    $ref: /schemas/types.yaml#/definitions/uint32
> +
> +required:
> +  - "#address-cells"
> +  - compatible
> +  - reg
> +  - "#interrupt-cells"
> +  - interrupt-controller
> +  - interrupts
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    interrupt-controller@10000018 {
> +      #address-cells = <0>;
> +      compatible = "brcm,bcm6345-ext-intc";
> +      reg = <0x10000018 0x4>;
> +
> +      interrupt-parent = <&periph_intc>;
> +      #interrupt-cells = <2>;
> +
> +      interrupt-controller;
> +      interrupts = <24>, <25>, <26>, <27>;
> +    };
> +
> +  - |
> +    interrupt-controller@fffe0014 {
> +      #address-cells = <0>;
> +      compatible = "brcm,bcm6345-ext-intc";
> +      reg = <0xfffe0014 0x4>;
> +
> +      interrupt-controller;
> +      #interrupt-cells = <2>;
> +
> +      interrupt-parent = <&cpu_intc>;
> +      interrupts = <3>, <4>, <5>, <6>;
> +
> +      brcm,field-width = <5>;
> +    };
> -- 
> 2.20.1
>