Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210305194206.3165917-1-elver@google.com> <20210305194206.3165917-2-elver@google.com>
In-Reply-To: <20210305194206.3165917-2-elver@google.com>
From:   Timur Tabi <timur@kernel.org>
Date:   Sat, 6 Mar 2021 14:27:58 -0600
Message-ID: <CAOZdJXXXweZG0Mgcf4LLt2SV3mONESunLwgx2c4rDaKrWevrYQ@mail.gmail.com>
Subject: Re: [PATCH 2/2] lib/vsprintf: reduce space taken by no_hash_pointers warning
To:     Marco Elver <elver@google.com>
Cc:     lkml <linux-kernel@vger.kernel.org>, vbabka@suse.cz,
        timur@kernel.org, Petr Mladek <pmladek@suse.com>,
        rostedt@goodmis.org,
        Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
        andriy.shevchenko@linux.intel.com,
        Rasmus Villemoes <linux@rasmusvillemoes.dk>,
        Geert Uytterhoeven <geert@linux-m68k.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Fri, Mar 5, 2021 at 1:46 PM Marco Elver <elver@google.com> wrote:
> +static const char no_hash_pointers_warning[8][55] __initconst = {
> +       "******************************************************",
> +       "   NOTICE NOTICE NOTICE NOTICE NOTICE NOTICE NOTICE   ",
> +       " This system shows unhashed kernel memory addresses   ",
> +       " via the console, logs, and other interfaces. This    ",
> +       " might reduce the security of your system.            ",
> +       " If you see this message and you are not debugging    ",
> +       " the kernel, report this immediately to your system   ",
> +       " administrator!                                       ",
> +};
> +
>  static int __init no_hash_pointers_enable(char *str)
>  {
> +       /* Indices into no_hash_pointers_warning; -1 is an empty line. */
> +       const int lines[] = { 0, 1, -1, 2, 3, 4, -1, 5, 6, 7, -1, 1, 0 };

You can save a few more bytes by making this an array of s8.

I agree with the __initconst.  The rest seems overkill to me, but I
won't reject it.

Acked-by: Timur Tabi <timur@kernel.org>