Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp684689pxb; Sat, 6 Mar 2021 13:19:22 -0800 (PST) X-Google-Smtp-Source: ABdhPJzvMroA2EVtMuVDJf5qceUDfZ35m/T6sUZqS4PvzUxCtQ+GRWpiqPeP1b2/3yU/eBj04SS7 X-Received: by 2002:a17:906:dfcc:: with SMTP id jt12mr8354931ejc.31.1615065562435; Sat, 06 Mar 2021 13:19:22 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1615065562; cv=none; d=google.com; s=arc-20160816; b=v0LFzjmMTX4h8PuBGIdEFdKQQVjUzuM+h62fh3tVkBc4uXo88NRfMsLgZ+yu+PG+xY 5f4c4mBAsKlN/JJOIJ063+Elq5qqXG04fzPmj0tRRkCMfBSwtrIcXHsaWVrIGjAl9fju /Oi0XtyY30qI5X7o55Vke53mPrVEnKcVfO3GDj011uORXobBdUjhwRCC2cxLMjyN25DB PfTHat0A/oqYoTRgIJLNo5NOFZMcrs7dy3JhUeJvoCy6rxOsVdfEBIlfUpe0FE917LXZ B29eiaZvcZjyGs4z8K4UWOKmYwZxGdXQGkXOFMJTRBAh6wxnn9kL44iUl5J72ItDhCqf QCiw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=IWHmhpA5Zif3jh65FB3tGXdQJMd1ekxEEqmbz03yaN8=; b=NMDaJ1XBQUny7wLD8q/fB44gl66NXEF9O1EDX2i2egHv7ce8R8urI3kNE7/fMo1d3d XlnZ3FyxjVvi0SiyZTTE2zFAjAfasYDeQdLPDIzUBUuw7cYXln3jhCT8CCouZM7l0dAf cv+93uneNxdqXC7iTLxow51XFhJPkBc9RUeSQPeqsgkTZgzy6n5D1mp6O74xWIWLcE9U Gt7wCqTSWE4jCGq9yGWHYkz2wxE4DPrBX4koLpxey28q906/FnGpv7bqplOF0KdDCKNk z0GjdLgszsehXwjbO4ZBV1RUp0xem05+rN/LncpRj1AA+AOnEEnlx76kE8FlglYtv4AF qFFA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id h18si4029909eds.493.2021.03.06.13.18.59; Sat, 06 Mar 2021 13:19:22 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229676AbhCFVSF (ORCPT + 99 others); Sat, 6 Mar 2021 16:18:05 -0500 Received: from mail-pg1-f171.google.com ([209.85.215.171]:45557 "EHLO mail-pg1-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229642AbhCFVRk (ORCPT ); Sat, 6 Mar 2021 16:17:40 -0500 Received: by mail-pg1-f171.google.com with SMTP id p21so3790338pgl.12; Sat, 06 Mar 2021 13:17:39 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=IWHmhpA5Zif3jh65FB3tGXdQJMd1ekxEEqmbz03yaN8=; b=gcsSKKsaeYXV3Dkb7X9eHHj0p+yR40+zJ6jToA6DdN+rcZAaB6I/LJmftAzMLz4Bgh GBQ3vQyVJAP3Ipfo/yo5chpFWR+zJv5xveJcrrsJupOaDeCo9Yohdrw/VoSGMRuXk8MP 7xwxcEubvAZ97n3m1RMAW8tnz+R0LzdR09r40w6Cql2/TeJYtLASYeC6iVCo+w7Xcz1o 7BKt2fwLlGyHuByqaiXaR3mtcFQdDINEsmpksCykoFmVI9PkXqQNc2p3Ca6D5qmeyR14 fhbhL6CCMwFO6RgKJfc7k2mPu3nV9yaHDrZXbEpzyeDizF5uW+ASAYNdMhvosUvEswdH ATgg== X-Gm-Message-State: AOAM531scKDywBBJbd+GhuL3RW/JdtmY1Fe/3UqTAkSXRE7syo8tsWa2 /+wH3zjRsbqpJDTjrZi/VA== X-Received: by 2002:a63:4808:: with SMTP id v8mr14093452pga.381.1615065457517; Sat, 06 Mar 2021 13:17:37 -0800 (PST) Received: from robh.at.kernel.org ([172.58.27.98]) by smtp.gmail.com with ESMTPSA id o62sm5696367pga.43.2021.03.06.13.17.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 06 Mar 2021 13:17:36 -0800 (PST) Received: (nullmailer pid 1227466 invoked by uid 1000); Sat, 06 Mar 2021 21:17:31 -0000 Date: Sat, 6 Mar 2021 14:17:31 -0700 From: Rob Herring To: =?iso-8859-1?Q?=C1lvaro_Fern=E1ndez?= Rojas Cc: jonas.gorski@gmail.com, Michael Turquette , Stephen Boyd , Philipp Zabel , Maxime Ripard , Nicolas Saenz Julienne , Stefan Wahren , Florian Fainelli , linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/4] mips: bmips: add BCM63268 timer reset definitions Message-ID: <20210306211731.GA1217377@robh.at.kernel.org> References: <20210225194201.17001-1-noltari@gmail.com> <20210225194201.17001-3-noltari@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20210225194201.17001-3-noltari@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Feb 25, 2021 at 08:41:59PM +0100, ?lvaro Fern?ndez Rojas wrote: > Add missing timer reset definitions for BCM63268. > > Signed-off-by: ?lvaro Fern?ndez Rojas > --- > include/dt-bindings/reset/bcm63268-reset.h | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/include/dt-bindings/reset/bcm63268-reset.h b/include/dt-bindings/reset/bcm63268-reset.h > index 6a6403a4c2d5..d87a7882782a 100644 > --- a/include/dt-bindings/reset/bcm63268-reset.h > +++ b/include/dt-bindings/reset/bcm63268-reset.h > @@ -23,4 +23,8 @@ > #define BCM63268_RST_PCIE_HARD 17 > #define BCM63268_RST_GPHY 18 > > +#define BCM63268_TRST_SW 29 > +#define BCM63268_TRST_HW 30 > +#define BCM63268_TRST_POR 31 Numbering should be local to the provider, so shouldn't this be 0-2? Unless these numbers correspond to something in the h/w (bit positions for example). > + > #endif /* __DT_BINDINGS_RESET_BCM63268_H */ > -- > 2.20.1 >