Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Sat, 6 Mar 2021 23:06:19 +0100
From:   Andreas Kemnade <andreas@kemnade.info>
To:     Jonathan =?UTF-8?B?TmV1c2Now6RmZXI=?= <j.neuschaefer@gmx.net>
Cc:     lee.jones@linaro.org, linux-kernel@vger.kernel.org,
        Mark Brown <broonie@kernel.org>
Subject: Re: [PATCH -next] mfd: ntxec: Support for EC in Tolino Shine 2 HD
Message-ID: <20210306230619.15ae787f@aktux>
In-Reply-To: <YEPj2ss13w5p+R4C@latitude>
References: <20210306181314.12673-1-andreas@kemnade.info>
        <YEPUppNWNiAMnczF@latitude>
        <20210306204219.6a7eae56@aktux>
        <YEPj2ss13w5p+R4C@latitude>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Sat, 6 Mar 2021 21:19:38 +0100
Jonathan Neusch=C3=A4fer <j.neuschaefer@gmx.net> wrote:

[...]
> > > > +	case NTXEC_VERSION_TOLINO_SHINE2:
> > > > +		has_rtc =3D false;
> > > > +		ec->regmap =3D devm_regmap_init(ec->dev, NULL,
> > > > +					      ec->regmap,
> > > > +					      &regmap_config_noack);   =20
> > >=20
> > > Ah=E2=80=94 A custom regmap stacked on top of the old regmap=E2=80=A6=
 I think this
> > > deserves a comment.
> > >  =20
> > Yes, devm_regmap_init_i2c() sets a different set of callbacks depending
> > on circumstances. Seems to be the easiest way to avoid duplicating too
> > much code. I really hope that there are not so much devices requiring
> > such a dirty stuff that adding such thing to the generic regmap code
> > would be justified. =20
>=20
> Ok, please add a short comment here or extend the one above the repmap
> config struct, to save interested readers a bit of trouble. I guess "add
> a wrapper" goes in right direction, but it didn't make the stacking
> obvious to me when I first read it.
>

I will wait for some days to see whether anybody chokes on that stack.

Regards,
Andreas