Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp744278pxb; Sat, 6 Mar 2021 16:00:59 -0800 (PST) X-Google-Smtp-Source: ABdhPJz4k6+g7Evz+Y8GK0mPtG735cWW53dbbXpckoX/DMHl0xX2C0f2pkbmqUkJSAvWxjPpZqOd X-Received: by 2002:a17:906:130c:: with SMTP id w12mr8587898ejb.253.1615075259087; Sat, 06 Mar 2021 16:00:59 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1615075259; cv=none; d=google.com; s=arc-20160816; b=PULxKyvAe4FC2/L9xe/ZuEWKSap/nCtu1eYcD5KdLfX7gG8MLKnubgKkLEiJBmSPfC 0KPdYSKlrXnxJodjPiL6V856/zCGOF6GMB42OA2mPbzOc8HeYBQWaBLWEbitYIfLNIL9 /YrFYpAK/k0visWcsW4FMTKAbvVNilG/e6teN7a/BlNvPWc856eI9FMTsuFB1QODbcuz Q3vgSOVdMUKMLfhz3MTFU282uEEB6LnCo92X7bQ2kzxE3rzMzneSkXerxCtNl/j+sVXc ADRa0wVeZzlSQr8mcHifGyoj7r5OUUvBPDMrqkQ6hiUbLl7SwDWNluEEWZ6mze/8p9hJ H2lQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=RkKHuuou1fbGpv6ZIX+yWrf0LwYVGw6dLWgr4M+rjOs=; b=wRd+HsGQ1BknENIqLsCA27S4o8jBk5u9pKE1jZ+/qGI2Hikvy+3tjWPty3b6Y7cqfF zm0Jcw93BkeUu+3orzOLNE9upK22TD+VIfkEJXRwXdc2gj0r1BEkfPDFxrwWfGKCqn1/ HoyPejSc2Iq9am7mfQapuuB46C1TJWiW8/TJyie9yYr1q3WMor20GTKKR5nUya6+ihev Lhg7Uq9qIBfz/P6xHV4UKN/tMWXabVhZ0PMzxn9ds8/DzKLTn8prT36yZ/A1rPNRb7nS Xko2USGPjIV2Jjjc21Z1S9qrVI+K3PUch4hmJHstHuAJJGCxpOvGl0RiIK/BsllgGom7 RigQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id ar21si4076129ejc.618.2021.03.06.16.00.36; Sat, 06 Mar 2021 16:00:59 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229816AbhCFX7i (ORCPT + 99 others); Sat, 6 Mar 2021 18:59:38 -0500 Received: from mail-ed1-f48.google.com ([209.85.208.48]:43892 "EHLO mail-ed1-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229719AbhCFX72 (ORCPT ); Sat, 6 Mar 2021 18:59:28 -0500 Received: by mail-ed1-f48.google.com with SMTP id bd6so8930220edb.10; Sat, 06 Mar 2021 15:59:27 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=RkKHuuou1fbGpv6ZIX+yWrf0LwYVGw6dLWgr4M+rjOs=; b=fqcvxAJTrQxBEbmFuzUiMRoHf7PMbOZuirBq6tqGl+9ue3VkAInI2JsUh6DmQqVWV6 tEixwNB70DdA+KzrxOPu9rPF1ZIivP1zTVyLMZLNRozbZ5rrmXPzoTIw0YL66sGP3PkW 9q06bP9pzbeOONNZiBFo8RMdqBQVQ5RzfA2O/iwBhO5yVRt1C41pvr+ujh9HA1z+tp/y MfPQRXUShVnIssh8P9ndb/OR076tPCmgdldV2Q/+Fq7NjNRBDTICH6JpfZevRmgcoqN/ j2BuVnGkbym0qhvgs27VS5rIn+HELw1Y8DgWfDRx7vUGTTn7EIut2vhDH+BL4c8VctOv Ku+g== X-Gm-Message-State: AOAM530sNewxeVvANZHWnSqF3iWMeYORG4+Wy6aDKO5vhwL0Ytniy5e3 z8VxPWA8ENOBO0SCghKV66o= X-Received: by 2002:aa7:ce8a:: with SMTP id y10mr15884345edv.66.1615075167183; Sat, 06 Mar 2021 15:59:27 -0800 (PST) Received: from rocinante ([95.155.85.46]) by smtp.gmail.com with ESMTPSA id r5sm4350727eds.49.2021.03.06.15.59.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 06 Mar 2021 15:59:26 -0800 (PST) Date: Sun, 7 Mar 2021 00:59:25 +0100 From: Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= To: Pali =?utf-8?B?Um9ow6Fy?= Cc: Marc Zyngier , Lorenzo Pieralisi , Rob Herring , Sandor Bodo-Merle , Ray Jui , Bjorn Helgaas , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] PCI: iproc: Fix return value of iproc_msi_irq_domain_alloc() Message-ID: References: <20210303142202.25780-1-pali@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20210303142202.25780-1-pali@kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Pali, > IRQ domain alloc function should return zero on success. Non-zero value > indicates failure. > > Signed-off-by: Pali Rohár > Fixes: fc54bae28818 ("PCI: iproc: Allow allocation of multiple MSIs") [...] Nice catch! Reviewed-by: Krzysztof Wilczyński Krzysztof