Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Sun, 7 Mar 2021 02:18:01 +0100
From:   Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= <kw@linux.com>
To:     chakravarthikulkarni <chakravarthikulkarni2021@gmail.com>
Cc:     "Rafael J. Wysocki" <rjw@rjwysocki.net>,
        Len Brown <lenb@kernel.org>,
        Bjorn Helgaas <helgaas@kernel.org>, linux-acpi@vger.kernel.org,
        linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] PCI: acpiphp:  Fixed coding style
Message-ID: <YEQpyWPgAI8az5gO@rocinante>
References: <20210301072145.19018-1-chakravarthikulkarni2021@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20210301072145.19018-1-chakravarthikulkarni2021@gmail.com>
Precedence: bulk

Hi,

Thank you for sending the patch over.  Few suggestions below.

There seem to be an extra space in the subject line.

> In this commit fixed coding style for braces and comments.

Where these coding style changes suggested by a tool?  For example, was it
something like checkpatch.pl?  If so, then it would be prudent to
mention that the script found these for future reference.

[...]
> -	struct list_head funcs;		/* one slot may have different
> -					   objects (i.e. for each function) */
> +	struct list_head funcs;		/* one slot may have different */
> +					/* objects (i.e. for each function) */
[...]

Above would be a single line commit that has been made to with within
the line length rules, as otherwise the line would be too long.

This is not necessarily something that we ought to fix, see for example:
  https://elixir.bootlin.com/linux/v5.11.3/source/include/linux/pci.h

[...]
> -struct acpiphp_attention_info
> -{
> +struct acpiphp_attention_info {
>  	int (*set_attn)(struct hotplug_slot *slot, u8 status);
>  	int (*get_attn)(struct hotplug_slot *slot, u8 *status);
>  	struct module *owner;
[...]

Nice catch!

Generally, you would also need to your full name when providing your
"Signed-off-by:" following the style that has been widely accepted.  See
git log for how it would normally look like, and also have a look at the
following for some general guidance on how to submit patches:

  https://www.kernel.org/doc/html/latest/process/submitting-patches.html

Krzysztof