Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Sender: Tejun Heo <htejun@gmail.com>
Date:   Sun, 7 Mar 2021 07:42:10 -0500
From:   Tejun Heo <tj@kernel.org>
To:     Jens Axboe <axboe@kernel.dk>
Cc:     Xunlei Pang <xlpang@linux.alibaba.com>,
        linux-block@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] blk-cgroup: Fix the recursive blkg rwstat
Message-ID: <YETKIo2iZpcd08Zk@slm.duckdns.org>
References: <1614932007-97224-1-git-send-email-xlpang@linux.alibaba.com>
 <4cc104d1-9aa3-a838-b786-9a808dd85945@kernel.dk>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4cc104d1-9aa3-a838-b786-9a808dd85945@kernel.dk>
Precedence: bulk

On Fri, Mar 05, 2021 at 11:32:05AM -0700, Jens Axboe wrote:
> On 3/5/21 1:13 AM, Xunlei Pang wrote:
> > The current blkio.throttle.io_service_bytes_recursive doesn't
> > work correctly.
> > 
> > As an example, for the following blkcg hierarchy:
> >  (Made 1GB READ in test1, 512MB READ in test2)
> >      test
> >     /    \
> >  test1   test2
> > 
> > $ head -n 1 test/test1/blkio.throttle.io_service_bytes_recursive
> > 8:0 Read 1073684480
> > $ head -n 1 test/test2/blkio.throttle.io_service_bytes_recursive
> > 8:0 Read 537448448
> > $ head -n 1 test/blkio.throttle.io_service_bytes_recursive
> > 8:0 Read 537448448
> > 
> > Clearly, above data of "test" reflects "test2" not "test1"+"test2".
> > 
> > Do the correct summary in blkg_rwstat_recursive_sum().
> 
> LGTM, Tejun?

Gees, that's horrible. Thanks for fixing this.

Acked-by: Tejun Heo <tj@kernel.org>

-- 
tejun