Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751401AbWJAHeh (ORCPT ); Sun, 1 Oct 2006 03:34:37 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751410AbWJAHeh (ORCPT ); Sun, 1 Oct 2006 03:34:37 -0400 Received: from ns2.uludag.org.tr ([193.140.100.220]:47026 "EHLO uludag.org.tr") by vger.kernel.org with ESMTP id S1751401AbWJAHeg (ORCPT ); Sun, 1 Oct 2006 03:34:36 -0400 From: Ismail Donmez Organization: =?utf-8?q?T=C3=9CB=C4=B0TAK/UEKAE?= To: Kyle Moffett Subject: Re: __STRICT_ANSI__ checks in headers Date: Sun, 1 Oct 2006 10:34:56 +0300 User-Agent: KMail/1.9.4 Cc: Andrew Morton , David Woodhouse , LKML , mchehab@infradead.org References: <200609150901.33644.ismail@pardus.org.tr> <20060930215343.548f5cd9.akpm@osdl.org> <110413A1-7699-4DDB-9997-C3DA9E9DDB46@mac.com> In-Reply-To: <110413A1-7699-4DDB-9997-C3DA9E9DDB46@mac.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200610011034.57158.ismail@pardus.org.tr> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1761 Lines: 44 On Sunday 01 October 2006 08:20, Kyle Moffett wrote: > On Oct 01, 2006, at 00:53:43, Andrew Morton wrote: [...] > > Bisection shows that this patch causes these depmod warnings: > > > > WARNING: "snd_card_disconnect" [sound/usb/usx2y/snd-usb-usx2y.ko] > > has no CRC! > > [etc] > > > > I don't know why that would happen. > > > > From: Ismail Donmez > > > > __STRICT_ANSI__ usage in types.h header results in compile errors > > for some userspace packages[1] when used with gcc -ansi flag. With > > the suggestion of Kyle Moffett I replace strict ansi checks with > > __extension__ to tell gcc not to error or warn on gcc extensions. > > Compile tested on x86 with 2.6.18. > > Best guess: Depmod does some kind of funny type-based expansion and > hashing of the symbols which doesn't understand the "__extension__" > keyword. Probably the simplest thing to do is to add "- > D__extension__=" to the depmod preprocessing flags. Alternatively > you could teach depmod to completely ignore the __extension__ keyword > when it shows up in the sources, but the former seems like it would > be much simpler. > > Just thinking about it we probably also need to educate sparse about > __extension__ too. Perhaps somebody could also add an sparse flag to > make it warn about nonportable constructs in exported header files. > > I'd submit a patch but my knowledge of kernel makefiles and depmod is > somewhere between zero and none, exclusive. Thanks, I will have a look at it. Regards, ismail - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/