Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp1578232pxb; Mon, 8 Mar 2021 00:39:20 -0800 (PST) X-Google-Smtp-Source: ABdhPJwWsGNSiZM7qb83yZTSvdGQV8NMryxfKr1u/ZBd8e6KFRE/sT36h7EsiCoZA05EuKqwxZKN X-Received: by 2002:a17:907:9862:: with SMTP id ko2mr13690356ejc.222.1615192760732; Mon, 08 Mar 2021 00:39:20 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1615192760; cv=none; d=google.com; s=arc-20160816; b=j9Wy9wTkEs7VXFflGu1aJkg5oCUk4S8a3bKVzsgPUoAH/fRLlduhgCgY6+rEGS9pd7 UQsczDEem05Xi0BWT7GXJAL8nLpeS2tH5iDSw79kT51BE1006YDmJa9ctIprYO16vCp/ j9lJkJZ8irICuq4WVQ84YBQgeBsvkq5CUO5/unmolPRuo+e3JuvxavLYy22BLhyqexKF KByrM9CnxmP/f20/WqnWYzmkW6R50+/6NPj3IuwukcdpBrjFscZlE49Pl2igaPFzHIOd l4x9QG+fADdgpUEcWl349HajyLSp54Le3J4g3zorFWbj82OF2TxDRPEphN0kk/Agkw6f 0hLA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to :mime-version:user-agent:date:message-id:from:cc:references:to :subject; bh=z5fdBv+Nn6G57lCuQ0MhvdfKrjHUn1o0zWBewB2hBI8=; b=sNNmbP0EChHWFlI8k2tzamF7Pa6J1p04yctz70v/Bd26ju3lRAXmVYdDgWIV9FHoSr 70INV1Q01Aeimyz29Ah+Vi4D05WltBvrgQp5XiJB1jdKoeNemGqM4UVZZi+B66LR4r5F 0RPiIa0XuN7MvpIZW70mx2O/yNVirQQAGJmazdPDbokpgrqx69wGnZeITrGN/uy1/4hH 0QH+dcywrZw15dvZAaZKRti30yFpniR5nIUzXRK6/Nca+ajZJE/CzZlxiw8nISt23E0M fcMCKE/7nyUL9U2zvTSoEg+iErvnTuLd/Ow1IO6RtLOf+QO1Sz07PxBFBLymGny/TRUb /DnQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id f24si6892281ejz.234.2021.03.08.00.38.58; Mon, 08 Mar 2021 00:39:20 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233894AbhCHDU0 (ORCPT + 99 others); Sun, 7 Mar 2021 22:20:26 -0500 Received: from szxga07-in.huawei.com ([45.249.212.35]:13865 "EHLO szxga07-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231294AbhCHDUR (ORCPT ); Sun, 7 Mar 2021 22:20:17 -0500 Received: from DGGEMS403-HUB.china.huawei.com (unknown [172.30.72.60]) by szxga07-in.huawei.com (SkyGuard) with ESMTP id 4Dv3T15rNxz7kKK; Mon, 8 Mar 2021 11:18:29 +0800 (CST) Received: from [10.174.178.215] (10.174.178.215) by smtp.huawei.com (10.3.19.203) with Microsoft SMTP Server (TLS) id 14.3.498.0; Mon, 8 Mar 2021 11:20:04 +0800 Subject: Re: [PATCH stable v5.10 0/7] arm64: Default to 32-bit wide ZONE_DMA To: Greg KH , Nicolas Saenz Julienne References: <20210303073319.2215839-1-jingxiangfeng@huawei.com> <9bc396116372de5b538d71d8f9ae9c3259f1002e.camel@suse.de> <827b317d7f5da6e048806922098291faacdb19f9.camel@suse.de> CC: , , , , , , , , , , , , , , , , , , , , , , , , , From: Jing Xiangfeng Message-ID: <604597E3.5000605@huawei.com> Date: Mon, 8 Mar 2021 11:20:03 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.178.215] X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2021/3/7 23:24, Greg KH wrote: > On Thu, Mar 04, 2021 at 04:09:28PM +0100, Nicolas Saenz Julienne wrote: >> On Thu, 2021-03-04 at 15:17 +0100, Greg KH wrote: >>> On Thu, Mar 04, 2021 at 03:05:32PM +0100, Nicolas Saenz Julienne wrote: >>>> Hi Greg. >>>> >>>> On Thu, 2021-03-04 at 14:46 +0100, Greg KH wrote: >>>>> On Wed, Mar 03, 2021 at 03:33:12PM +0800, Jing Xiangfeng wrote: >>>>>> Using two distinct DMA zones turned out to be problematic. Here's an >>>>>> attempt go back to a saner default. >>>>> What problem does this solve? How does this fit into the stable kernel >>>>> rules? >>>> We changed the way we setup memory zones in arm64 in order to cater for >>>> Raspberry Pi 4's weird DMA constraints: ZONE_DMA spans the lower 1GB of memory >>>> and ZONE_DMA32 the rest of the 32bit address space. Since you can't allocate >>>> memory that crosses zone boundaries, this broke crashkernel allocations on big >>>> machines. This series fixes all this by parsing the HW description and checking >>>> for DMA constrained buses. When not found, the unnecessary zone creation is >>>> skipped. >>> What kernel/commit caused this "breakage"? >> 1a8e1cef7603 arm64: use both ZONE_DMA and ZONE_DMA32 > Thanks for the info, all now queued up. There is a fix in 5.11. Please consider applying the following commit to 5.10.y: aed5041ef9a3 of: unittest: Fix build on architectures without CONFIG_OF_ADDRES Thanks > > greg k-h > . >