Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp1578254pxb; Mon, 8 Mar 2021 00:39:24 -0800 (PST) X-Google-Smtp-Source: ABdhPJzr8MJPscRY/Lkvce1KQKOagPHaLnHPiH89OKFbf3CtK2TQn/YqwS0GW6VJpFHJlV3Y3Aek X-Received: by 2002:a17:907:77d4:: with SMTP id kz20mr13948882ejc.93.1615192763991; Mon, 08 Mar 2021 00:39:23 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1615192763; cv=none; d=google.com; s=arc-20160816; b=BunvFgTy8i/x2axAAzTkAvVZj7ZD2VfZxbG0XZDn9Zbq6QUxVXKPaZNE8iFUVBtkVN 0fncP+XxRuQuzwO/ozpE4KgUza18Duf7q3G6NfcalVOvd/0Rbe9vR7kqjWO05inoXAHA HdXmDUuPsiq06nfp50tTEIZjPU2/wUxaLpOy97YSahSTRJIUOHOK+g83jGtRMXByICaK 91NF/O9sMIqf46HGK4vvRc2y5dyZW+Lc+V/CWO2nRXRR9EyU11OaW+QrA/RqhHr2GSnK bQNg/zuzViINozilHMciDvROVox+CZf5dHHHEx76CJpfTOW5u6JfHekHaqhBoL89pBzJ IzoA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:subject:cc:to:from; bh=4399Iq3aFlX9ZF9olwuPTSu7YaxdOylfQacXSOs1jdM=; b=EEpqMDmg3AOSK0QMhk6pyXXQuS0cpO39NbbGgXASwxLMwIT4Cav2Dlgnt3TPVsldwl Sl3JaH2s3Ycpeg6+H49LoGHNGyixNdz1zRp7ZsEHxDvMBbDp/4C8GaiRzfXKTd2/M4L8 dL+6F0496ZcS+k0d5jr9Ndof6kInxy+/RAjAYEgNvQl5eynDM8cf6OonLz9aT/Okgrbt WlpctrFWWxmI6OfjcrDezJ2ROgOoRxTnDpd2qWf/DXD51MHoCi4x/d6qw13bLAgkAo/7 W1srGhaIUQ50a+lZ2xPhVF6JWIXhN8F4YmKnhxLD5qbbZf3dwxb0hDs0z4Msyn6NJtwf vhgw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id e12si6669602ejs.501.2021.03.08.00.39.01; Mon, 08 Mar 2021 00:39:23 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233907AbhCHD0c (ORCPT + 99 others); Sun, 7 Mar 2021 22:26:32 -0500 Received: from out30-130.freemail.mail.aliyun.com ([115.124.30.130]:53933 "EHLO out30-130.freemail.mail.aliyun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230359AbhCHD0A (ORCPT ); Sun, 7 Mar 2021 22:26:00 -0500 X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R161e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e04426;MF=jiapeng.chong@linux.alibaba.com;NM=1;PH=DS;RN=5;SR=0;TI=SMTPD_---0UQp6Dbg_1615173956; Received: from j63c13417.sqa.eu95.tbsite.net(mailfrom:jiapeng.chong@linux.alibaba.com fp:SMTPD_---0UQp6Dbg_1615173956) by smtp.aliyun-inc.com(127.0.0.1); Mon, 08 Mar 2021 11:25:58 +0800 From: Jiapeng Chong To: jejb@linux.ibm.com Cc: martin.petersen@oracle.com, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, Jiapeng Chong Subject: [PATCH] scsi: aha1542: remove unneeded semicolon Date: Mon, 8 Mar 2021 11:25:51 +0800 Message-Id: <1615173951-34692-1-git-send-email-jiapeng.chong@linux.alibaba.com> X-Mailer: git-send-email 1.8.3.1 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fix the following coccicheck warnings: ./drivers/scsi/aha1542.c:693:2-3: Unneeded semicolon. ./drivers/scsi/aha1542.c:674:2-3: Unneeded semicolon. ./drivers/scsi/aha1542.c:656:2-3: Unneeded semicolon. ./drivers/scsi/aha1542.c:621:2-3: Unneeded semicolon. Reported-by: Abaci Robot Signed-off-by: Jiapeng Chong --- drivers/scsi/aha1542.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/scsi/aha1542.c b/drivers/scsi/aha1542.c index 21aab9f..6e34767 100644 --- a/drivers/scsi/aha1542.c +++ b/drivers/scsi/aha1542.c @@ -618,7 +618,7 @@ static int aha1542_getconfig(struct Scsi_Host *sh) default: shost_printk(KERN_ERR, sh, "Unable to determine IRQ level.\n"); return -1; - }; + } sh->this_id = inquiry_result[2] & 7; return 0; } @@ -653,7 +653,7 @@ static int aha1542_mbenable(struct Scsi_Host *sh) if (aha1542_out(sh->io_port, mbenable_cmd, 3)) goto fail; - }; + } while (0) { fail: shost_printk(KERN_ERR, sh, "Mailbox init failed\n"); @@ -669,9 +669,9 @@ static int aha1542_query(struct Scsi_Host *sh) u8 inquiry_result[4]; int i; i = inb(STATUS(sh->io_port)); - if (i & DF) { + if (i & DF) i = inb(DATA(sh->io_port)); - }; + aha1542_outb(sh->io_port, CMD_INQUIRY); aha1542_in(sh->io_port, inquiry_result, 4, 0); if (!wait_mask(INTRFLAGS(sh->io_port), INTRMASK, HACC, 0, 0)) @@ -690,7 +690,7 @@ static int aha1542_query(struct Scsi_Host *sh) if (inquiry_result[0] == 0x43) { shost_printk(KERN_INFO, sh, "Emulation mode not supported for AHA-1740 hardware, use aha1740 driver instead.\n"); return 1; - }; + } /* * Always call this - boards that do not support extended bios translation -- 1.8.3.1