Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp1580363pxb; Mon, 8 Mar 2021 00:44:18 -0800 (PST) X-Google-Smtp-Source: ABdhPJwo9koWbl1qJvLnlEiafSghTMazcQFYK2AQkhAK+zfjWnY02XGjWzfbzXVcTp/OmEvzEvpx X-Received: by 2002:a05:6402:254f:: with SMTP id l15mr1908532edb.189.1615193058556; Mon, 08 Mar 2021 00:44:18 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1615193058; cv=none; d=google.com; s=arc-20160816; b=GHwpZfgj9Um0kXhr8gQXqXoOmnQnp4MAymfb30sB3WPZMeJQuFInEinTi8+TLZWRwY +adQTokXY12hSCsDsgs6tQA+aTqOzxw7F2GiHekkzmEU1FEz+GEzrVdUKzaVrCfulRXT Oa2nGi8xQ6gr/M5yNVryS2/s7P6Mq1/5uzrkr5lMs8CrhiN5JPj4DO0IYKlZj9SnvDuO EIELL4DMID5I7T5TxTbwFxHIJ4bI6j/V0akYDgitzdDTm4mleL8q+dM+AwWiE0qC8edp kTvWmDL4q0EGbkSJFb1gYDOhcp3yNnUZAqdQjR+9QeGe/n8m1xIzSlynM4NdXJ5EJdSR 0shQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=UNoEYKDBGTzOJeT/EP06qqm1sw++l0u4ofBeIhu+mFQ=; b=sjzJujS+3M9/hrlEGKAdavL3pks2uHQFLAaxIrtWVjCwXusiX1wj/mcY7F/sP5M2+C 2IPr8RdtBStORK1yZL9U8Z9YnAXv/awjbZMj8lgZhJKa1hAtwaC795A9r7hhkHfifi7V Jl7BohoG7FSFzjuCz0Kq0yv6rjkkwXhVNFOwYBlcvyR8XXY2B+xl+jWZSg5dXsINFFc9 gECevwz5iw7sFfSwjqXlHCjtOcgXLGUoiNBM9pfef687vSCL6MhojbrkpJmVp7kA6efd TJ28qPKENW7itbeektGXNpxubxE+14Iw+oE0mbR3s9n8N2LwFS53ZnVj890+udV1xdU9 3r/Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=kkGBMFqK; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id h16si1021610ejt.695.2021.03.08.00.43.56; Mon, 08 Mar 2021 00:44:18 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=kkGBMFqK; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234387AbhCHFIx (ORCPT + 99 others); Mon, 8 Mar 2021 00:08:53 -0500 Received: from fllv0016.ext.ti.com ([198.47.19.142]:38072 "EHLO fllv0016.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234334AbhCHFIW (ORCPT ); Mon, 8 Mar 2021 00:08:22 -0500 Received: from fllv0035.itg.ti.com ([10.64.41.0]) by fllv0016.ext.ti.com (8.15.2/8.15.2) with ESMTP id 12858HoQ023656; Sun, 7 Mar 2021 23:08:17 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1615180097; bh=UNoEYKDBGTzOJeT/EP06qqm1sw++l0u4ofBeIhu+mFQ=; h=From:To:CC:Subject:Date:In-Reply-To:References; b=kkGBMFqKaCMFT2cdpHYS0/xT5zBGCTDbhSo6LEzrSkC9V7HH13ml4JfETb/chMaB8 4R5oOnJ9aJZt3pMjoaLx/1lKSWz6frBGXKtCuJUYLJAFVuWEjEQl+N4g6EpbI63X63 QWMTfQ/ZvAocYTxcxpqQxOAtRO4Y/K48XjJsCgno= Received: from DLEE102.ent.ti.com (dlee102.ent.ti.com [157.170.170.32]) by fllv0035.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 12858HH4068766 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Sun, 7 Mar 2021 23:08:17 -0600 Received: from DLEE110.ent.ti.com (157.170.170.21) by DLEE102.ent.ti.com (157.170.170.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3; Sun, 7 Mar 2021 23:08:17 -0600 Received: from lelv0327.itg.ti.com (10.180.67.183) by DLEE110.ent.ti.com (157.170.170.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3 via Frontend Transport; Sun, 7 Mar 2021 23:08:17 -0600 Received: from a0393678-ssd.dhcp.ti.com (ileax41-snat.itg.ti.com [10.172.224.153]) by lelv0327.itg.ti.com (8.15.2/8.15.2) with ESMTP id 12857aL8086547; Sun, 7 Mar 2021 23:08:14 -0600 From: Kishon Vijay Abraham I To: Kishon Vijay Abraham I , Vinod Koul , Rob Herring , Philipp Zabel , Swapnil Jakhade CC: , , Lokesh Vutla Subject: [PATCH v5 10/13] phy: cadence: cadence-sierra: Add missing clk_disable_unprepare() in .remove callback Date: Mon, 8 Mar 2021 10:37:29 +0530 Message-ID: <20210308050732.7140-11-kishon@ti.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20210308050732.7140-1-kishon@ti.com> References: <20210308050732.7140-1-kishon@ti.com> MIME-Version: 1.0 Content-Type: text/plain X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org commit 44d30d622821("phy: cadence: Add driver for Sierra PHY") enabled the clock in probe and failed to disable in remove callback. Add missing clk_disable_unprepare() in cdns_sierra_phy_remove(). Fixes: 44d30d622821("phy: cadence: Add driver for Sierra PHY") Signed-off-by: Kishon Vijay Abraham I --- drivers/phy/cadence/phy-cadence-sierra.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/phy/cadence/phy-cadence-sierra.c b/drivers/phy/cadence/phy-cadence-sierra.c index a45278c30948..ac32b7b0289f 100644 --- a/drivers/phy/cadence/phy-cadence-sierra.c +++ b/drivers/phy/cadence/phy-cadence-sierra.c @@ -689,6 +689,9 @@ static int cdns_sierra_phy_remove(struct platform_device *pdev) reset_control_assert(phy->phys[i].lnk_rst); reset_control_put(phy->phys[i].lnk_rst); } + + clk_disable_unprepare(phy->input_clks[PHY_CLK]); + return 0; } -- 2.17.1