Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp1580733pxb; Mon, 8 Mar 2021 00:45:02 -0800 (PST) X-Google-Smtp-Source: ABdhPJyI48ztO1YsuBfRNhfFw3UjSMUjrywQ8B//+tJS0F4NpqF0gfCg8l8BgHhPdosvTaKslpSH X-Received: by 2002:a17:907:119b:: with SMTP id uz27mr13714192ejb.464.1615193102719; Mon, 08 Mar 2021 00:45:02 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1615193102; cv=none; d=google.com; s=arc-20160816; b=lv+CFp1pM2qEC2Algcn6iLPvhcfhunaod+vJ8K8+CS4ZmSqlqpS42y3y3KTv5UJWtW vfmzvf5pR7iWyVcVGs/8+GV89N3alj5CmOpCWpl2APJXuiU0IrwUH7Yq4b2gh5Uh3kcc m6ICP8hT9YPt2OtncPUegmQw/TtOXa2UDxtNzNl27E+nrnCJwgMHB2MeQjaQEs7tMwA8 mkeMJsWqfNPemyoNaDrQxIIkKCLv+b425EsRBgAFtBB/wh2rrSnrKmb5NCY5ffZdNrin jvorCJdCnSjH7oyoR6PkG2pffaC7GynhjVhKOv82aCDqeWv7PK12fcGr4BIEexGEcj86 SETg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=Famt9+QW7fJmZvkWG2HQTcMD7Zc2bqcZSOAXqYjJYQM=; b=t3Fp9Y36wtGVRrPs+ipzFfOGOysklWl2P+HkX8vk1HxJnp/sY2X8TLeqww8x11ZDP7 lN98KctTI3E5QCjhj/L4+gPwItx+TVO3ta67rE6bj1eMY5jrYnmay4AHz1w+sa4R0Sbd Ui3ZcXSKqOdasvzlsXm28GNCB+oN/Woz++PI0KGN+SPf7iGsOWPAtxddOC4WpDAZ2HNZ 9GWLrUIuIdFpD+RckRRCb7iRUrVyGVuGnR9TuKVOFC6WnKxi+KvB3UzuxpWiV8B72lcg z9YwiHnKtuXC/sBxubmxd4Wpn9Su8QXGzyKsWBchuXwmNYa9dBoI8/RSdbTCUMJiPCRT QHXg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id m24si7191956eda.304.2021.03.08.00.44.40; Mon, 08 Mar 2021 00:45:02 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235082AbhCHHJV (ORCPT + 99 others); Mon, 8 Mar 2021 02:09:21 -0500 Received: from verein.lst.de ([213.95.11.211]:54397 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230477AbhCHHJS (ORCPT ); Mon, 8 Mar 2021 02:09:18 -0500 Received: by verein.lst.de (Postfix, from userid 2407) id D9B6A68B02; Mon, 8 Mar 2021 08:09:15 +0100 (CET) Date: Mon, 8 Mar 2021 08:09:15 +0100 From: "hch@lst.de" To: "Williams, Dan J" Cc: "hch@lst.de" , lkp , "hare@suse.de" , "olkuroch@cisco.com" , "linux-nvdimm@lists.01.org" , "lkp@lists.01.org" , "ming.lei@redhat.com" , "linux-kernel@vger.kernel.org" , "axboe@kernel.dk" , "Sang, Oliver" , "martin.petersen@oracle.com" Subject: Re: [block] 52f019d43c: ndctl.test-libndctl.fail Message-ID: <20210308070915.GA32695@lst.de> References: <20210305055900.GC31481@xsang-OptiPlex-9020> <20210305074204.GA17414@lst.de> <6f40b1f53c029788e20fe175618d8772e36d648c.camel@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6f40b1f53c029788e20fe175618d8772e36d648c.camel@intel.com> User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Mar 06, 2021 at 08:33:04PM +0000, Williams, Dan J wrote: > Yes, it looks like my unit test checks for exactly the behavior you > changed. It was convenient to test that the device could be switched > back to rw via BLKROSET, but I don't require that. The new behaviour of > letting the disk->ro take precedence makes more sense to me, so I'll > update the test for the new behaviour. > > I.e. I don't think regressing a unit test counts as a userspace > regression. Ok, thanks for the confirmation.