Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp1580869pxb; Mon, 8 Mar 2021 00:45:15 -0800 (PST) X-Google-Smtp-Source: ABdhPJyJG1Z84JlgUnroJE6YobAMejEf9yPZTB30TpeOwG6SVxOKL6CX3iePclfIVi+ncEEU9VfR X-Received: by 2002:a05:6402:c96:: with SMTP id cm22mr20994526edb.128.1615193115186; Mon, 08 Mar 2021 00:45:15 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1615193115; cv=none; d=google.com; s=arc-20160816; b=mBqSpbYP2p3ysJwIQlLdJHhCuhb1jBm9FgCnJf5JyFodvps1Sm1oJZNEEukRINcPHC QFdYYtWSpOeKZEWtCUtlvDKSqpgsqUVKoEJsHJMgZs9mqLPHeCf9HsjWwBrTgi32LBV6 MGZ/tltmtXTBSzrtygM5HKs5itAeSPqSzv1hCGLjOzr2+NKS6FFgmuAFTw4H7xekE5I3 K3GaGij3TyE2oKzjz9PtHQFUvHcWq3jQKUb1PKohLVztCkvJ8YYnztCFSx6fu/EUlVpP W5R/pcoRwob0bm1xMsU69z4bKe2MMIH+qjEh2/CLkqCi68Zj22xPYn3aJwOJbayGK2sK mtpg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:subject:cc:to:from; bh=/pN08Gad8yFq7Ovpws+6aTg9U7ppyVsvViU5U01Y4ks=; b=gDQ4UsPynq3sfg//h/ys1TPXpoTbGvQlfQvs0qJW13ERn69kC/qbkYqmPA1pqfWazs uSfNsSpv7+Jr6jFzMqZQDx8B6R9HOekelFELYiSYMZ8xB/1nRgCmIDgfZ2lAd3yiHUdk zQgWbyaKhIE+ewraHJHn7JkVD9CYOMxW2corpaeYtnWh1e4Szhrkti67KQICSwVUk4H9 9N8epA/ck7eWqK11aLVmiWQ/25HL57cfekYnYKgef+xOL4WU+W85GpCd7tBMSChhjXD7 Pt/eJzGUWdwdan0ESJS8+yo1d8nGXsgRjqX/mbZBCQ8hffQzea2SIvpCcGkdJgz2FzwQ WE8Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id bx20si6594486edb.215.2021.03.08.00.44.52; Mon, 08 Mar 2021 00:45:15 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232686AbhCHHTV (ORCPT + 99 others); Mon, 8 Mar 2021 02:19:21 -0500 Received: from out30-54.freemail.mail.aliyun.com ([115.124.30.54]:53770 "EHLO out30-54.freemail.mail.aliyun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229704AbhCHHS6 (ORCPT ); Mon, 8 Mar 2021 02:18:58 -0500 X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R841e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e04394;MF=yang.lee@linux.alibaba.com;NM=1;PH=DS;RN=10;SR=0;TI=SMTPD_---0UQr502d_1615187936; Received: from j63c13417.sqa.eu95.tbsite.net(mailfrom:yang.lee@linux.alibaba.com fp:SMTPD_---0UQr502d_1615187936) by smtp.aliyun-inc.com(127.0.0.1); Mon, 08 Mar 2021 15:18:56 +0800 From: Yang Li To: perex@perex.cz Cc: tiwai@suse.com, rjui@broadcom.com, sbranden@broadcom.com, bcm-kernel-feedback-list@broadcom.com, alsa-devel@alsa-project.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, lgirdwood@gmail.com, Yang Li Subject: [PATCH] ASoC: bcm: add missing call to of_node_put() Date: Mon, 8 Mar 2021 15:18:54 +0800 Message-Id: <1615187934-39505-1-git-send-email-yang.lee@linux.alibaba.com> X-Mailer: git-send-email 1.8.3.1 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org In one of the error paths of the for_each_child_of_node() loop, add missing call to of_node_put(). Fix the following coccicheck warning: ./sound/soc/bcm/cygnus-ssp.c:1346:1-33: WARNING: Function "for_each_available_child_of_node" should have of_node_put() before return around line 1352. Reported-by: Abaci Robot Signed-off-by: Yang Li --- sound/soc/bcm/cygnus-ssp.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/sound/soc/bcm/cygnus-ssp.c b/sound/soc/bcm/cygnus-ssp.c index 6e634b4..aa16a23 100644 --- a/sound/soc/bcm/cygnus-ssp.c +++ b/sound/soc/bcm/cygnus-ssp.c @@ -1348,8 +1348,10 @@ static int cygnus_ssp_probe(struct platform_device *pdev) &cygnus_ssp_dai[active_port_count]); /* negative is err, 0 is active and good, 1 is disabled */ - if (err < 0) + if (err < 0) { + of_node_put(child_node); return err; + } else if (!err) { dev_dbg(dev, "Activating DAI: %s\n", cygnus_ssp_dai[active_port_count].name); -- 1.8.3.1