Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [RFC 1/1] s390/pci: expose a PCI device's UID as its index
To:     Niklas Schnelle <schnelle@linux.ibm.com>,
        =?UTF-8?Q?Krzysztof_Wilczy=c5=84ski?= <kw@linux.com>
Cc:     Bjorn Helgaas <helgaas@kernel.org>,
        Narendra K <narendra_k@dell.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Stefan Raspl <raspl@linux.ibm.com>,
        Peter Oberparleiter <oberpar@linux.ibm.com>,
        linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-s390@vger.kernel.org
References: <20210303095250.1360007-1-schnelle@linux.ibm.com>
 <20210303095250.1360007-2-schnelle@linux.ibm.com>
 <YEU7iFjxNxQK3ldc@rocinante>
 <c714ca55-7189-e196-7b8d-f02da555b399@linux.ibm.com>
From:   Viktor Mihajlovski <mihajlov@linux.ibm.com>
Message-ID: <e2f45e3e-210b-0b98-c8bd-bbe6609b85f1@linux.ibm.com>
Date:   Mon, 8 Mar 2021 09:42:37 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.7.0
MIME-Version: 1.0
In-Reply-To: <c714ca55-7189-e196-7b8d-f02da555b399@linux.ibm.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Precedence: bulk


On 3/8/21 8:02 AM, Niklas Schnelle wrote:
> 
> 
> On 3/7/21 9:46 PM, Krzysztof Wilczyński wrote:
>> Hi Niklas,
>>
>> [...]
>>> +static ssize_t index_show(struct device *dev,
>>> +			  struct device_attribute *attr, char *buf)
>>> +{
>>> +	struct zpci_dev *zdev = to_zpci(to_pci_dev(dev));
>>> +	u32 index = ~0;
>>> +
>>> +	if (zpci_unique_uid)
>>> +		index = zdev->uid;
>>> +
>>> +	return sprintf(buf, "%u\n", index);
>> [...]
>>
>> Would it be possible to use the new sysfs_emit() rather than sprintf()
>> even though the zpci_attr macro and still use mio_enabled_show() still
>> would use sprintf().  What do you think?
>>
>> See https://www.kernel.org/doc/html/latest/filesystems/sysfs.html for
>> the changes in the internal API.
>>
>> Krzysztof
>>
> 
> Of course that makes sense and thanks for pointing me to this API!
> @Viktor, may I carry your R-b over?
> 
Sure, please go ahead.
> I'll also update the other attributes in a clean up patch.
> 
> Thanks,
> Niklas
> 

-- 
Kind Regards,
    Viktor